[jira] [Commented] (SOLR-15474) pluggable support for custom circuit breakers

["Christine Poerschke (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361858#comment-17361858 ] 

Christine Poerschke commented on SOLR-15474:
--------------------------------------------

In [https://github.com/apache/solr/pull/96#discussion_r644383152] onwards making circuit breakers pluggable was mentioned.

In the (totally unrelated) [https://github.com/apache/solr/pull/166#discussion_r648547301] I pointed to {{SolrPluginUtils.invokeSetters}} and doing that and the previous circuit breakers pluggable mentions reminded me of the SOLR-8621 and SOLR-5730 work quite some time ago where {{invokeSetters}} is also used e.g. [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.8.2/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L333-L335] code.

Well, and then I sort of "fell into" a little coding experiment ...
 * and in case it might be useful somehow I've pushed it to a git branch: christine-to-add-link-here
 * and it must be emphasised this is just playing around with code and with one idea somewhat hidden in plain sight in the experiment and that idea is for the {{CircuitBreakerConfig}} to not form part of the {{CircuitBreaker}} constructor signature and for circuit breaker parameters to be set via setters instead (and that also means that {{cpuThresholt}} instead of {{cpuThreshold}} style typos will automatically throw an error)
 * and what any configuration would look like and how to transition from old to new configuration and if/how the {{CircuitBreakerManager/CircuitBreaker}} interaction is affected by the pluggability, none of that was considered since it was just a little coding experiment.

That's it, experiment concluded and just sharing "as is" the experiment artifacts.

> pluggable support for custom circuit breakers
> ---------------------------------------------
>
>                 Key: SOLR-15474
>                 URL: https://issues.apache.org/jira/browse/SOLR-15474
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Christine Poerschke
>            Priority: Major
>
> In https://github.com/apache/solr/pull/96#discussion_r644383152 onwards making circuit breakers pluggable was mentioned.
> Creating this ticket as a placeholder for such potential future work (but I have to plans to work on it myself at this time).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org