You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by ClaudiaPHI <gi...@git.apache.org> on 2016/05/23 08:49:18 UTC
[GitHub] metamodel pull request: Feature/small changes to fixed width
GitHub user ClaudiaPHI opened a pull request:
https://github.com/apache/metamodel/pull/105
Feature/small changes to fixed width
Modified FixedWidthReader so that we can feed a line to a reader independently.
The modification were necessary for integrating fixed width files on Hadoop: https://github.com/datacleaner/DataCleaner/issues/1343
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ClaudiaPHI/metamodel feature/small-changes-to-fixed-width
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 918ed47fe93e46c9dd9da08bfebe8690894a5c2a
Author: claudiap <cl...@humaninference.com>
Date: 2016-05-20T13:25:46Z
changes required to create a fixed width datastore based on a resource.
commit 173f5b04605bdc680b0082ab42f96dfd1732868f
Author: claudiap <cl...@humaninference.com>
Date: 2016-05-23T08:42:02Z
small fix for exception handling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/small changes to fixed width
Posted by ClaudiaPHI <gi...@git.apache.org>.
Github user ClaudiaPHI commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221210380
I need to wait for this PR: https://github.com/apache/metamodel/pull/103 if I am to avoid conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/small changes to fixed width
Posted by ClaudiaPHI <gi...@git.apache.org>.
Github user ClaudiaPHI commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221182651
I am providing the lines of data. I need to be able to use this class without the BufferReader. I will add a unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #105: Feature/small changes to fixed width
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/105
OK let's merge this and maybe some day improve it as per my remarks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #105: Feature/small changes to fixed width
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/small changes to fixed width
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221043058
I feel a bit like I am missing a unit test for this kind of usage.
An I wonder if that will reveal a slight abstraction issue... The reader today takes a Resource as a constructor argument. Would you have any resource to provide it with when you are yourself providing the lines of data?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/small changes to fixed width
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221327239
+0
Code is acceptable from me, but I think it would be better to separate "parser" from "reader" here. A reader is a stateful thing IMO - it has a pointer/cursor to some data that it is reading through and it is also closeable. The parsing part however can have a different scope or maybe even be completely stateless. So I would prefer if we make two different classes for it (the reader will probably use the parser, but not the other way around).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---