You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by ashnazg <gi...@git.apache.org> on 2015/10/29 22:50:31 UTC

[GitHub] storm pull request: STORM-1127: allow for boolean arguments

GitHub user ashnazg opened a pull request:

    https://github.com/apache/storm/pull/832

    STORM-1127:  allow for boolean arguments

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ashnazg/storm boolArgs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #832
    
----
commit a03b419dc30ae12ac9dd8a3e814c017ebc3ddbac
Author: Chuck Burgess <cb...@progressrail.com>
Date:   2015-10-29T21:44:28Z

    allow for boolean arguments;

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1127: allow for boolean arguments (Flux)

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/832#issuecomment-154510125
  
    To me the code looks good.  +1, but I would like someone more familiar with Flux to also take a look.
    
    @ptgoetz can you take a look, or point out someone who would be good to review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1127: allow for boolean arguments (Flux)

Posted by ptgoetz <gi...@git.apache.org>.

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/832#issuecomment-154521316
  
    +1. Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1127: allow for boolean arguments (Flux)

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/832


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---