You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 16:17:10 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request, #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
AnonHxy opened a new pull request, #17527:
URL: https://github.com/apache/pulsar/pull/17527
### Motivation
* Fix `org.apache.pulsar.client.impl.PulsarClientImpl#scheduledExecutorProvider` not shutdown
### Modifications
* Shut down `scheduledExecutorProvider`
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1243165430
@nicoloboschi PTAL. This is a release blocker for 2.10.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1240278743
@Technoboy- @codelipenghui This PR fixed the bug introduced by #16334, which is included in 2.11.0. Can we also add this in 2.11.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1240405026
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
URL: https://github.com/apache/pulsar/pull/17527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1241425593
> It looks like the null-check is still needed
Fixed. @nicoloboschi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1240144078
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1241389078
> @Technoboy- @codelipenghui This PR fixed the bug introduced by #16334, which is included in 2.11.0. Can we also add this in 2.11.0?
yes, sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1243174898
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17527:
URL: https://github.com/apache/pulsar/pull/17527#issuecomment-1240706705
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #17527: [fix][client]Fix scheduledExecutorProvider not shutdown
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #17527:
URL: https://github.com/apache/pulsar/pull/17527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org