[GitHub] [knox] rlevas commented on issue #72: KNOX-1820 - Cleanup KeystoreService implementations and add unit tests

[GitBox <gi...@apache.org>]

rlevas commented on issue #72: KNOX-1820 - Cleanup KeystoreService implementations and add unit tests
URL: https://github.com/apache/knox/pull/72#issuecomment-472960625
 
 
   I am not sure what the Travis failure.  The unit tests run fine for me:
   ```
   mvn -T1C verify -Dsurefire.useFile=false -Djavax.net.ssl.trustStorePassword=changeit -DargLine="-Djdk.net.URLClassPath.disableClassPathURLCheck=true" -B -V
   ...
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time: 10:32 min (Wall Clock)
   [INFO] Finished at: 2019-03-14T12:41:39-04:00
   [INFO] Final Memory: 338M/1964M
   [INFO] ------------------------------------------------------------------------
   ```
   
   Plus the error is not in a touched class:
   ```
   ERROR]   RemoteConfigurationRegistryJAASConfigTest.shouldRaiseAnErrorWithMeaningfulErrorMessageIfAuthLoginConfigCannotBeRead Expected test to throw (an instance of org.apache.knox.gateway.config.ConfigurationException and exception with message a string starting with "Error while getting secure configuration. This error usually indicates an issue within the supplied JAAS configuration")
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services