[jira] [Comment Edited] (CASSANDRA-3564) flush before shutdown so restart is faster

["David Alves (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406093#comment-13406093 ] 

David Alves edited comment on CASSANDRA-3564 at 7/3/12 9:58 PM:
----------------------------------------------------------------

I'm trying to wrap this up...

I changed nodecmd to handle the expected exception nicely (the EOF one because thrift was closed on the other side). the "cassandra" shell script does not deal with PID reading/killing. So I was wondering should we include this functionality in "cassandra", i.e., call nodetool, read/check pid wait and kill, or should we deal with it within nodetool (maybe make the flushAndExit function return the PID to nodetool and have that kill the process if required).


                
      was (Author: dr-alves):
    I'm trying to wrap this up...

I changed nodecmd to handle the expected exception nicely (the EOF one because thrift was closed on the other side). the "cassandra" shell script does not deal with PID reading/killing. So I was wondering should we include this call nodetool, read/check pid and kill funcionality in  "cassandra" or should we deal with it within nodetool (maybe make the flushAndExit function return the PID to nodetool and have that kill the process if required).


                  
> flush before shutdown so restart is faster
> ------------------------------------------
>
>                 Key: CASSANDRA-3564
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3564
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Packaging
>            Reporter: Jonathan Ellis
>            Assignee: David Alves
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: 3564.patch
>
>
> Cassandra handles flush in its shutdown hook for durable_writes=false CFs (otherwise we're *guaranteed* to lose data) but leaves it up to the operator otherwise.  I'd rather leave it that way to offer these semantics:
> - cassandra stop = shutdown nicely [explicit flush, then kill -int]
> - kill -INT = shutdown faster but don't lose any updates [current behavior]
> - kill -KILL = lose most recent writes unless durable_writes=true and batch commits are on [also current behavior]
> But if it's not reasonable to use nodetool from the init script then I guess we can just make the shutdown hook flush everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira