[GitHub] [spark] srowen commented on a diff in pull request #38832: SPARK-41313 Combine fixes for SPARK-3900 and SPARK-21138

[GitBox <gi...@apache.org>]

srowen commented on code in PR #38832:
URL: https://github.com/apache/spark/pull/38832#discussion_r1035091858


##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -240,6 +240,9 @@ private[spark] class ApplicationMaster(
 
       logInfo("ApplicationAttemptId: " + appAttemptId)
 
+      // During shutdown, we may not be able to create an FileSystem object. So, pre-create here.
+      val stagingDirPath = new Path(System.getenv("SPARK_YARN_STAGING_DIR"))
+      val stagingDirFs = stagingDirPath.getFileSystem(yarnConf)

Review Comment:
   I'm having trouble seeing how the logic is different before and after.  In both cases, the FS is obtained from `new Path(System.getenv("SPARK_YARN_STAGING_DIR"))` in the same way, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org