You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/08/19 07:48:04 UTC
[GitHub] [incubator-brpc] zbzbw opened a new pull request, #1896: fix: flamegraph initialization
zbzbw opened a new pull request, #1896:
URL: https://github.com/apache/incubator-brpc/pull/1896
Currently the <script> tag inside returned data from `flamegraph.pl` is dropped by jQuery, and `init` won't work (so does features like zoom in/out: https://github.com/apache/incubator-brpc/pull/864#issuecomment-1149521212)
This PR fixed the issue mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1896: fix: flamegraph initialization
Posted by GitBox <gi...@apache.org>.
zyearn commented on PR #1896:
URL: https://github.com/apache/incubator-brpc/pull/1896#issuecomment-1221379611
Could you write something more about how you tested the code? For example, what's the difference in UI before and after?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org