You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2019/10/25 22:07:16 UTC

[hadoop] branch branch-3.1 updated: HDFS-14923. Remove dead code from HealthMonitor. Contributed by Fei Hui.

This is an automated email from the ASF dual-hosted git repository.

weichiu pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/branch-3.1 by this push:
     new 287fab6  HDFS-14923. Remove dead code from HealthMonitor. Contributed by Fei Hui.
287fab6 is described below

commit 287fab63465f88553f909d0c7b8a9bc612ce0e77
Author: Fei Hui <fe...@gmail.com>
AuthorDate: Fri Oct 25 15:05:31 2019 -0700

    HDFS-14923. Remove dead code from HealthMonitor. Contributed by Fei Hui.
    
    Signed-off-by: Wei-Chiu Chuang <we...@apache.org>
    (cherry picked from commit 7be5508d9b35892f483ba6022b6aced7648b8fa3)
    (cherry picked from commit 54d3e212bfdcc6b473969a70faca339184849e61)
---
 .../src/main/java/org/apache/hadoop/ha/HealthMonitor.java  | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HealthMonitor.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HealthMonitor.java
index d1a858f..5f2c806 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HealthMonitor.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HealthMonitor.java
@@ -134,19 +134,11 @@ public class HealthMonitor {
   public void addCallback(Callback cb) {
     this.callbacks.add(cb);
   }
-  
-  public void removeCallback(Callback cb) {
-    callbacks.remove(cb);
-  }
 
   public synchronized void addServiceStateCallback(ServiceStateCallback cb) {
     this.serviceStateCallbacks.add(cb);
   }
 
-  public synchronized void removeServiceStateCallback(ServiceStateCallback cb) {
-    serviceStateCallbacks.remove(cb);
-  }
-
   public void shutdown() {
     LOG.info("Stopping HealthMonitor thread");
     shouldRun = false;
@@ -258,11 +250,7 @@ public class HealthMonitor {
   synchronized State getHealthState() {
     return state;
   }
-  
-  synchronized HAServiceStatus getLastServiceStatus() {
-    return lastServiceState;
-  }
-  
+
   boolean isAlive() {
     return daemon.isAlive();
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org