You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "Wu Sheng (JIRA)" <ji...@apache.org> on 2017/01/11 08:02:58 UTC
[jira] [Commented] (ROCKETMQ-43) code style file didn't match
check-style in typecast
[ https://issues.apache.org/jira/browse/ROCKETMQ-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817583#comment-15817583 ]
Wu Sheng commented on ROCKETMQ-43:
----------------------------------
There are both NoWhitespaceBefore and WhitespaceAfter modules in checkstyle.xml, like this:
<module name="NoWhitespaceBefore"/>
<module name="WhitespaceAfter"/>
> code style file didn't match check-style in typecast
> ----------------------------------------------------
>
> Key: ROCKETMQ-43
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-43
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Wu Sheng
> Assignee: vongosling
> Priority: Critical
>
> I have already add RocketMQ's style file, and use IntelliJ to format file, still fail on style-check like this:
> [INFO] Starting audit...
> /home/travis/build/wu-sheng/incubator-rocketmq/namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java:105:47: error: 'typecast' is not followed by whitespace.
> In intelliJ auto-format:
> LoggerContext lc = (LoggerContext)LoggerFactory.getILoggerFactory();
> But in style-check:
> LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory();
> It got my crazy... when I change some classes, which include cast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)