You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2023/01/09 23:23:00 UTC

[jira] [Comment Edited] (ORC-1348) TimezoneImpl constructor should pass std::vector<> & instead of std::vector<>

    [ https://issues.apache.org/jira/browse/ORC-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656331#comment-17656331 ] 

Dongjoon Hyun edited comment on ORC-1348 at 1/9/23 11:22 PM:
-------------------------------------------------------------

No problem at all, [~zhjwpku]. I wanted to give those tips to help you. :)


was (Author: dongjoon):
No problem at all, [~zhjwpku]. I want to give those tips to help you. :)

> TimezoneImpl constructor should pass std::vector<> & instead of std::vector<>
> -----------------------------------------------------------------------------
>
>                 Key: ORC-1348
>                 URL: https://issues.apache.org/jira/browse/ORC-1348
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: master
>            Reporter: Junwang Zhao
>            Priority: Minor
>             Fix For: master
>
>
> TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes) should
> change to TimezoneImpl(const std::string& name, const std::vector<unsigned char>& bytes) to reduce copy constructor of vector of unsigned char.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)