[GitHub] [incubator-tvm] cbalint13 commented on pull request #6416: add -static-libgcc to target_link_libraries for tvm to fix arm64 nati…

[GitBox <gi...@apache.org>]

cbalint13 commented on pull request #6416:
URL: https://github.com/apache/incubator-tvm/pull/6416#issuecomment-688651372


   > Is it possible to use the compiler RT function instead?
   > 
   > https://github.com/apache/incubator-tvm/blob/master/3rdparty/compiler-rt/builtin_fp16.h#L165
   > 
   > It would be useful to use this function so that the code itself is platform agnostic.
   
   Or even better, can use internal instead of ```reinterpret_cast<__fp16*>``` ?
   
   * Function: https://github.com/apache/incubator-tvm/blob/master/src/runtime/builtin_fp16.cc
   * Example:  https://github.com/apache/incubator-tvm/blob/master/src/relay/transforms/pattern_util.h#L252
   
   @tom-gall , 
   Cc @junrushao1994 , @tqchen 
   
   If want i can make a separate PR with the proposed ```reinterpret_cast<__fp16*>``` replacement.
   However ```reinterpret_cast<__fp16*>``` is more elegant indeed (if toolchains would agree with us too).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org