You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by sansanichfb <gi...@git.apache.org> on 2016/09/20 00:42:46 UTC
[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/915
HAWQ-1052. Fixed extraction logic for boolean datatype.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1052
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #915
----
commit 293f5b90d85ec8acf2ef23ac3f1681c8fff95158
Author: Oleksandr Diachenko <od...@pivotal.io>
Date: 2016-09-20T00:42:08Z
HAWQ-1052. Fixed extraction logic for boolean datatype.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/915#discussion_r79740167
--- Diff: src/backend/access/external/pxfheaders.c ---
@@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input)
if (proj_info != NULL && proj_info->pi_isVarList)
{
List* qualsAttributes = extractPxfAttributes(input->quals);
-
- add_projection_desc_httpheader(headers, proj_info, qualsAttributes);
+ /* projection information is incomplete if columns from WHERE clause wasn't extracted */
+ if (qualsAttributes != NIL || list_length(input->quals) == 0)
--- End diff --
Why is the check for `list_length(input->quals)` with `0`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/915#discussion_r79740844
--- Diff: src/backend/access/external/pxfheaders.c ---
@@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input)
if (proj_info != NULL && proj_info->pi_isVarList)
{
List* qualsAttributes = extractPxfAttributes(input->quals);
-
- add_projection_desc_httpheader(headers, proj_info, qualsAttributes);
+ /* projection information is incomplete if columns from WHERE clause wasn't extracted */
+ if (qualsAttributes != NIL || list_length(input->quals) == 0)
--- End diff --
Ok, got it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/915#discussion_r79740591
--- Diff: src/backend/access/external/pxfheaders.c ---
@@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input)
if (proj_info != NULL && proj_info->pi_isVarList)
{
List* qualsAttributes = extractPxfAttributes(input->quals);
-
- add_projection_desc_httpheader(headers, proj_info, qualsAttributes);
+ /* projection information is incomplete if columns from WHERE clause wasn't extracted */
+ if (qualsAttributes != NIL || list_length(input->quals) == 0)
--- End diff --
extractPxfAttributes function might return NIL in two cases - when input quals are empty or some error occurred during extraction. So this condition list_length(input->quals) == 0 means no input quals has been passed thus nothing was extracted and it's safe to add projection info.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #915: HAWQ-1052. Fixed extraction logic for boolean dat...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on the issue:
https://github.com/apache/incubator-hawq/pull/915
Aside from my confusion with my comment, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---