You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/02 14:36:11 UTC

[GitHub] [kafka] mumrah opened a new pull request #9246: Minor: publish static analysis reports in PR builds

mumrah opened a new pull request #9246:
URL: https://github.com/apache/kafka/pull/9246


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mumrah commented on pull request #9246: Minor: publish static analysis reports in PR builds

Posted by GitBox <gi...@apache.org>.
mumrah commented on pull request #9246:
URL: https://github.com/apache/kafka/pull/9246#issuecomment-692093776


   Closing this since ASF's Jenkins will strip off any CSS for HTML reports which seriously limits the usefulness of viewing these reports. Will move streams quickstart fix to a separate PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mumrah commented on pull request #9246: Minor: publish static analysis reports in PR builds

Posted by GitBox <gi...@apache.org>.
mumrah commented on pull request #9246:
URL: https://github.com/apache/kafka/pull/9246#issuecomment-686659842


   Ok, it seems to work, but it is pretty ugly https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-9246/Checkstyle_20Report


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 commented on a change in pull request #9246: Minor: publish static analysis reports in PR builds

Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9246:
URL: https://github.com/apache/kafka/pull/9246#discussion_r482211220



##########
File path: Jenkinsfile
##########
@@ -31,6 +31,25 @@ def doValidation() {
         spotlessScalaCheck checkstyleMain checkstyleTest spotbugsMain rat \
         --profile --no-daemon --continue -PxmlSpotBugsReport=true
   '''
+  publishHTML([
+    allowMissing: false, 
+    alwaysLinkToLastBuild: false, 
+    includes: '**/build/reports/checkstyle/*',
+    keepAll: false, 
+    reportDir: '',
+    reportFiles: 'main.html', 

Review comment:
       How about including ```test.html```?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] mumrah closed pull request #9246: Minor: publish static analysis reports in PR builds

Posted by GitBox <gi...@apache.org>.
mumrah closed pull request #9246:
URL: https://github.com/apache/kafka/pull/9246


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org