You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/28 21:58:41 UTC
[jira] [Commented] (SAMZA-1172) Fix for the topological sort to
handle single-node loop correctly
[ https://issues.apache.org/jira/browse/SAMZA-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946044#comment-15946044 ]
ASF GitHub Bot commented on SAMZA-1172:
---------------------------------------
GitHub user xinyuiscool opened a pull request:
https://github.com/apache/samza/pull/100
SAMZA-1172: Fix for the topological sort to handle single-node loop
In the processor graph, the topological sort missed adding to the visited set during graph traversal. This caused wrong graph being generated for single-node loop. This is fixed in the patch.
Also fixed the maxPartition method not handling empty collection correctly.
Added a few new unit tests for these. Also adjust the timing of previous async commit unit tests so it can run more reliably. Long term wise we need to fix the timer inside the AsyncRunLoop tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xinyuiscool/samza SAMZA-1172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit f1fc26dc18922ad0437b8853ca249f73bd39f85b
Author: Xinyu Liu <xi...@xiliu-ld.linkedin.biz>
Date: 2017-03-28T21:28:50Z
SAMZA-1172: Fix for the topological sort to handle single-node loop correctly
commit 938cbca048619bed9a1a9396691c4b713d5df30b
Author: Xinyu Liu <xi...@xiliu-ld.linkedin.biz>
Date: 2017-03-28T21:52:57Z
Update the wait timer for asycn unit tests
----
> Fix for the topological sort to handle single-node loop correctly
> -----------------------------------------------------------------
>
> Key: SAMZA-1172
> URL: https://issues.apache.org/jira/browse/SAMZA-1172
> Project: Samza
> Issue Type: Bug
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: Blocker
>
> In the processor graph, the topological sort missed adding to the visited set during graph traversal. This caused wrong graph being generated for single-node loop.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)