You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/13 17:16:40 UTC
[GitHub] [shardingsphere] soulasuna opened a new pull request, #17644: Add acquire ACK locked instances in cluster mode
soulasuna opened a new pull request, #17644:
URL: https://github.com/apache/shardingsphere/pull/17644
## Add acquire ACK locked instances in cluster mode
Fixes #17621.
Changes proposed in this pull request:
- Add acquire ACK locked instances in cluster mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17644: Add acquire ACK locked instances in cluster mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17644:
URL: https://github.com/apache/shardingsphere/pull/17644#issuecomment-1126628057
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17644?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17644](https://codecov.io/gh/apache/shardingsphere/pull/17644?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d56e14) into [master](https://codecov.io/gh/apache/shardingsphere/commit/4435f41bc439375db69bf31e208860cb2d0ec765?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4435f41) will **decrease** coverage by `0.01%`.
> The diff coverage is `5.26%`.
```diff
@@ Coverage Diff @@
## master #17644 +/- ##
============================================
- Coverage 58.87% 58.86% -0.02%
+ Complexity 2125 2123 -2
============================================
Files 3583 3585 +2
Lines 53374 53408 +34
Branches 9105 9110 +5
============================================
+ Hits 31426 31436 +10
- Misses 19294 19318 +24
Partials 2654 2654
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tor/lock/global/AbstractGlobalLockNodeService.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL2dsb2JhbC9BYnN0cmFjdEdsb2JhbExvY2tOb2RlU2VydmljZS5qYXZh) | `90.00% <ø> (-0.91%)` | :arrow_down: |
| [...cluster/coordinator/lock/mutex/InterMutexLock.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL211dGV4L0ludGVyTXV0ZXhMb2NrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ator/lock/mutex/ShardingSphereMutexLockHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL211dGV4L1NoYXJkaW5nU3BoZXJlTXV0ZXhMb2NrSG9sZGVyLmphdmE=) | `53.33% <ø> (-1.51%)` | :arrow_down: |
| [...rdinator/lock/mutex/node/MutexLockNodeService.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL211dGV4L25vZGUvTXV0ZXhMb2NrTm9kZVNlcnZpY2UuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...dinator/lock/service/MutexLockRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL3NlcnZpY2UvTXV0ZXhMb2NrUmVnaXN0cnlTZXJ2aWNlLmphdmE=) | `28.57% <0.00%> (-21.43%)` | :arrow_down: |
| [...ock/service/ReentrantMutexLockRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL3NlcnZpY2UvUmVlbnRyYW50TXV0ZXhMb2NrUmVnaXN0cnlTZXJ2aWNlLmphdmE=) | `40.00% <0.00%> (-4.45%)` | :arrow_down: |
| [...er/cluster/coordinator/lock/util/LockNodeUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL3V0aWwvTG9ja05vZGVVdGlsLmphdmE=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../global/database/node/DatabaseLockNodeService.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL2dsb2JhbC9kYXRhYmFzZS9ub2RlL0RhdGFiYXNlTG9ja05vZGVTZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../infra/rewrite/engine/GenericSQLRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9lbmdpbmUvR2VuZXJpY1NRTFJld3JpdGVFbmdpbmUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...ngsphere/sqltranslator/rule/SQLTranslatorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yL3NoYXJkaW5nc3BoZXJlLXNxbC10cmFuc2xhdG9yLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbHRyYW5zbGF0b3IvcnVsZS9TUUxUcmFuc2xhdG9yUnVsZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/shardingsphere/pull/17644/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17644?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17644?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4435f41...6d56e14](https://codecov.io/gh/apache/shardingsphere/pull/17644?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #17644: Add acquire ACK locked instances in cluster mode
Posted by GitBox <gi...@apache.org>.
zjcnb merged PR #17644:
URL: https://github.com/apache/shardingsphere/pull/17644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org