You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/30 12:14:56 UTC
[GitHub] [dubbo-go-pixiu] yqxu opened a new pull request #262: add trie for route
yqxu opened a new pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262
**What this PR does**: add trie struct for route request to matched filter
**Does this PR introduce a user-facing change?**: remove head match for request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5173847) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/9ea3feab604ae29ef166df8179a9e43b1b5dcb0f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ea3fea) will **increase** coverage by `2.31%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.46% +2.31%
===========================================
Files 62 56 -6
Lines 3321 3417 +96
===========================================
+ Hits 1101 1212 +111
+ Misses 2106 2084 -22
- Partials 114 121 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.59% <71.59%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ea3fea...5173847](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-955172026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (045a98b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/d1930df3e910c5f948380c703fbbce4f49490d2d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1930df) will **increase** coverage by `2.45%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.93% 36.38% +2.45%
===========================================
Files 61 55 -6
Lines 3165 3262 +97
===========================================
+ Hits 1074 1187 +113
+ Misses 1979 1956 -23
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d1930df...045a98b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8060098) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ec68432b71b733a1d87b7a182ded2004fed073d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec68432) will **increase** coverage by `2.40%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.98% 36.38% +2.40%
===========================================
Files 61 55 -6
Lines 3160 3262 +102
===========================================
+ Hits 1074 1187 +113
+ Misses 1974 1956 -18
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec68432...8060098](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8060098) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ec68432b71b733a1d87b7a182ded2004fed073d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec68432) will **increase** coverage by `2.40%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.98% 36.38% +2.40%
===========================================
Files 61 55 -6
Lines 3160 3262 +102
===========================================
+ Hits 1074 1187 +113
+ Misses 1974 1956 -18
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec68432...8060098](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#discussion_r719963074
##########
File path: pkg/common/router/router.go
##########
@@ -54,23 +55,50 @@ func (rm *RouterCoordinator) Route(hc *http.HttpContext) (*model.RouteAction, er
return rm.activeConfig.Route(hc.Request)
}
+func getTrieKey(method string, path string, isPrefix bool) string {
+ if isPrefix {
+ return method + constant.PathSlash + path + constant.PathSlash + "**"
+ }
+ return method + constant.PathSlash + path
+}
+
// OnAddRouter add router
func (rm *RouterCoordinator) OnAddRouter(r *model.Router) {
+ //锁粒度 下期优化到 字典树node 级别
Review comment:
第一，在此处加上 TODO
第二，不要使用中文注释
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway commented on a change in pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
MasterKenway commented on a change in pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#discussion_r720799834
##########
File path: pkg/common/constant/http.go
##########
@@ -43,3 +43,10 @@ const (
PprofDefaultAddress = "0.0.0.0"
PprofDefaultPort = 7070
)
+
+const (
+ Get = "GET"
+ Put = "PUT"
+ Post = "POST"
+ Delete = "DELETE"
+)
Review comment:
What about using constant defined in the net/http?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8060098) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ec68432b71b733a1d87b7a182ded2004fed073d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec68432) will **increase** coverage by `2.40%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.98% 36.38% +2.40%
===========================================
Files 61 55 -6
Lines 3160 3262 +102
===========================================
+ Hits 1074 1187 +113
+ Misses 1974 1956 -18
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec68432...8060098](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (045a98b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/d1930df3e910c5f948380c703fbbce4f49490d2d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1930df) will **increase** coverage by `2.45%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.93% 36.38% +2.45%
===========================================
Files 61 55 -6
Lines 3165 3262 +97
===========================================
+ Hits 1074 1187 +113
+ Misses 1979 1956 -23
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d1930df...045a98b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#discussion_r724706513
##########
File path: pkg/common/router/trie/trie.go
##########
@@ -43,14 +43,14 @@ func NewTrieWithDefault(path string, defVal interface{}) Trie {
// Node
type Node struct {
lock sync.RWMutex
- matchStr string //冗余信息 通配节点冗余变量名，普通节点冗余节点名
+ matchStr string
childInitOnce sync.Once
- children map[string]*Node //子树
- PathVariablesSet map[string]*Node //变量名集合 找不到set先用map todo
- PathVariableNode *Node //通配变量节点后的子树
- MatchAllNode *Node //通配变量节点后的子树
- endOfPath bool //是否是路径末尾
- bizInfo interface{} //随便塞啥
+ children map[string]*Node
Review comment:
还是尽量加些注释，那把你通过 translate.baidu.com 机器翻译下也好
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019f3e8) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1663747a0648805768b7efec98b3318270ae680f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1663747) will **increase** coverage by `2.42%`.
> The diff coverage is `72.77%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.57% +2.42%
===========================================
Files 62 56 -6
Lines 3321 3407 +86
===========================================
+ Hits 1101 1212 +111
+ Misses 2106 2075 -31
- Partials 114 120 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `75.00% <75.00%> (ø)` | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1663747...019f3e8](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50977bf) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1663747a0648805768b7efec98b3318270ae680f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1663747) will **increase** coverage by `2.40%`.
> The diff coverage is `72.05%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.55% +2.40%
===========================================
Files 62 56 -6
Lines 3321 3409 +88
===========================================
+ Hits 1101 1212 +111
+ Misses 2106 2076 -30
- Partials 114 121 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `74.11% <74.11%> (ø)` | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1663747...50977bf](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2081e44) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/8080a476f38363ea779a54793e228e97003770f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8080a47) will **increase** coverage by `2.33%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.14% 35.48% +2.33%
===========================================
Files 62 56 -6
Lines 3322 3416 +94
===========================================
+ Hits 1101 1212 +111
+ Misses 2107 2083 -24
- Partials 114 121 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.59% <71.59%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8080a47...2081e44](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94b752c) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/9ea3feab604ae29ef166df8179a9e43b1b5dcb0f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ea3fea) will **increase** coverage by `2.31%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.46% +2.31%
===========================================
Files 62 56 -6
Lines 3321 3417 +96
===========================================
+ Hits 1101 1212 +111
+ Misses 2106 2084 -22
- Partials 114 121 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.59% <71.59%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ea3fea...94b752c](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6c50b8) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ec68432b71b733a1d87b7a182ded2004fed073d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec68432) will **increase** coverage by `2.46%`.
> The diff coverage is `70.28%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.98% 36.45% +2.46%
===========================================
Files 61 55 -6
Lines 3160 3256 +96
===========================================
+ Hits 1074 1187 +113
+ Misses 1974 1950 -24
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.59% <71.59%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec68432...f6c50b8](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9941a73) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1663747a0648805768b7efec98b3318270ae680f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1663747) will **increase** coverage by `2.42%`.
> The diff coverage is `72.77%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.57% +2.42%
===========================================
Files 62 56 -6
Lines 3321 3407 +86
===========================================
+ Hits 1101 1212 +111
+ Misses 2106 2075 -31
- Partials 114 120 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `75.00% <75.00%> (ø)` | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1663747...9941a73](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#discussion_r725495702
##########
File path: pkg/common/router/trie/trie.go
##########
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package trie
+
+import (
+ "github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil"
+ "github.com/pkg/errors"
+)
+
+// Trie
+type Trie struct {
+ root Node
+}
+
+// NewTrie
+func NewTrie() Trie {
+ return Trie{root: Node{endOfPath: false, matchStr: ""}}
+}
+
+// NewTrieWithDefault
+func NewTrieWithDefault(path string, defVal interface{}) Trie {
+ ret := Trie{root: Node{endOfPath: false, matchStr: ""}}
+ _, _ = ret.Put(path, defVal)
+ return ret
+}
+
+// Node
+type Node struct {
+ matchStr string //abc match abc, :a match all words as a variable names a , * match all words ,** match all words and children.
+ children map[string]*Node // in path /a/b/c , b is child of a , c is child of b
+ PathVariablesSet map[string]*Node // in path /:a/b/c/:d , :a is a path variable node of level1 , :d is path variable node of level4
+ PathVariableNode *Node // in path /:a/b/c/:d , /b/c/:d is a child tree of pathVariable node :a ,and some special logic for match pathVariable it better not store in children.
+ MatchAllNode *Node // /a/b/** /** is a match all Node.
+ endOfPath bool // if true means a real path exists , /a/b/c/d only node of d is true, a,b,c is false.
+ bizInfo interface{} // route info and any other info store here.
+}
+
+//IsEmpty put key and values into trie as map.
+func (trie *Trie) IsEmpty() bool {
+ return trie.root.IsEmpty()
+}
+
+//Put put key and values into trie as map.
+func (trie *Trie) Put(withOutHost string, bizInfo interface{}) (bool, error) {
+ if bizInfo == nil {
+ return false, errors.Errorf("data to put should not be nil.")
+ }
+ parts := stringutil.Split(withOutHost)
+ return trie.root.Put(parts, bizInfo)
+}
+
+//Get get values according key.pathVariable not supported.
+func (trie Trie) Get(withOutHost string) (*Node, []string, bool, error) {
+ parts := stringutil.Split(withOutHost)
+ node, param, ok, e := trie.root.Get(parts)
+ length := len(param)
+ for i := 0; i < length/2; i++ {
+ temp := param[length-1-i]
+ param[length-1-i] = param[i]
+ param[i] = temp
+ }
+ return node, param, ok, e
+}
+
+//Match get values according url , pathVariable supported.
+func (trie Trie) Match(withOutHost string) (*Node, []string, bool) {
+ parts := stringutil.Split(withOutHost)
+ node, param, ok := trie.root.Match(parts)
+ length := len(param)
+ for i := 0; i < length/2; i++ {
+ temp := param[length-1-i]
+ param[length-1-i] = param[i]
+ param[i] = temp
+ }
+ return node, param, ok
+}
+
+//Remove remove key and value from trie. logic delete can't release memory, rebuild if necessary when lake of memory.
+func (trie Trie) Remove(withOutHost string) error {
+ n, _, _, e := trie.Get(withOutHost)
+ if e != nil {
+ return e
+ }
+ if n != nil {
+ n.endOfPath = false
+ }
+ return errors.Errorf("path not exists.")
+}
+
+//Contains return if key exists in trie
+func (trie Trie) Contains(withOutHost string) (bool, error) {
+ parts := stringutil.Split(withOutHost)
+ ret, _, _, e := trie.root.Get(parts)
+ if e != nil {
+ return true, e
+ }
+ return !(ret == nil), nil
+}
+
+//不对外暴露，不推荐外部使用
+
+//Put node put
+func (node *Node) Put(keys []string, bizInfo interface{}) (bool, error) {
+ //空节点初始化
+ if node.children == nil {
+ node.children = map[string]*Node{}
+ }
+ if len(keys) == 0 {
+ return true, nil
+ }
+
+ key := keys[0]
+ // isReal 代表是否是输入url 最末尾那段,对应trie 上的节点是否真实存在。
+ isReal := len(keys) == 1
+ //屏蔽 通配和非统配的细节put 方法，不涉及递归
+ isSuccess := node.put(key, isReal, bizInfo)
+ //递归退出条件
+ if !isSuccess {
+ return false, nil
+ }
+ childKeys := keys[1:]
+
+ //递归体
+ if stringutil.IsPathVariableOrWildcard(key) {
+ return node.PathVariableNode.Put(childKeys, bizInfo)
+ } else if stringutil.IsMatchAll(key) {
+ return isSuccess, nil
+ } else {
+ return node.children[key].Put(childKeys, bizInfo)
+ }
+
+}
+
+//IsEmpty return true if empty
+func (node *Node) IsEmpty() bool {
+ if node.children == nil && node.matchStr == "" && node.PathVariableNode == nil && node.PathVariablesSet == nil {
+ return true
+ }
+ return false
+}
+
+//GetBizInfo get info
+func (node *Node) GetBizInfo() interface{} {
+ return node.bizInfo
+}
+
+//Match node match
+func (node *Node) Match(parts []string) (*Node, []string, bool) {
+ key := parts[0]
+ childKeys := parts[1:]
+ // isEnd 代表是否是输入url 最末尾那段,对应trie 上的节点是否真实存在。
+ isEnd := len(childKeys) == 0
+ if isEnd {
+ //退出条件
+ if node.children != nil && node.children[key] != nil && node.children[key].endOfPath {
+ return node.children[key], []string{}, true
+ }
+ //不能直接return 需要一次回朔 O（2n） trie下存在：/aaa/bbb/xxxxx/ccc/ddd /aaa/bbb/:id/ccc 输入url：/aaa/bbb/xxxxx/ccc
+ if node.PathVariableNode != nil {
+ if node.PathVariableNode.endOfPath {
+ return node.PathVariableNode, []string{key}, true
+ }
+ }
+
+ } else {
+ //递归体
+ if node.children != nil && node.children[key] != nil {
+ n, param, ok := node.children[key].Match(childKeys)
+ if ok {
+ return n, param, ok
+ }
+ }
+ //同理需要回朔
+ if node.PathVariableNode != nil {
+ n, param, ok := node.PathVariableNode.Match(childKeys)
+ param = append(param, key)
+ if ok {
+ return n, param, ok
+ }
+ }
+ }
+ if node.children != nil && node.children[key] != nil && node.children[key].MatchAllNode != nil {
+ return node.children[key].MatchAllNode, []string{}, true
+ }
+ if node.MatchAllNode != nil {
+ return node.MatchAllNode, []string{}, true
+ }
+ return nil, nil, false
+}
+
+//Get node get
+func (node *Node) Get(keys []string) (*Node, []string, bool, error) {
+ key := keys[0]
+ childKeys := keys[1:]
+ isReal := len(childKeys) == 0
+ if isReal {
+ //退出条件
Review comment:
apache 项目注释不要写中文，改成英文
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6c50b8) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ec68432b71b733a1d87b7a182ded2004fed073d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec68432) will **increase** coverage by `2.46%`.
> The diff coverage is `70.28%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.98% 36.45% +2.46%
===========================================
Files 61 55 -6
Lines 3160 3256 +96
===========================================
+ Hits 1074 1187 +113
+ Misses 1974 1950 -24
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.59% <71.59%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec68432...f6c50b8](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6c50b8) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ec68432b71b733a1d87b7a182ded2004fed073d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec68432) will **increase** coverage by `2.46%`.
> The diff coverage is `70.28%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.98% 36.45% +2.46%
===========================================
Files 61 55 -6
Lines 3160 3256 +96
===========================================
+ Hits 1074 1187 +113
+ Misses 1974 1950 -24
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.59% <71.59%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec68432...f6c50b8](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f33afd7) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/425b3800a888b04464de4101703baf3e8e1ecdea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (425b380) will **increase** coverage by `2.43%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.70% 36.14% +2.43%
===========================================
Files 61 55 -6
Lines 3198 3295 +97
===========================================
+ Hits 1078 1191 +113
+ Misses 2008 1985 -23
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [425b380...f33afd7](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f33afd7) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/425b3800a888b04464de4101703baf3e8e1ecdea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (425b380) will **increase** coverage by `2.43%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.70% 36.14% +2.43%
===========================================
Files 61 55 -6
Lines 3198 3295 +97
===========================================
+ Hits 1078 1191 +113
+ Misses 2008 1985 -23
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [425b380...f33afd7](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb4cf3b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1663747a0648805768b7efec98b3318270ae680f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1663747) will **increase** coverage by `2.39%`.
> The diff coverage is `72.27%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.54% +2.39%
===========================================
Files 62 56 -6
Lines 3321 3407 +86
===========================================
+ Hits 1101 1211 +110
+ Misses 2106 2076 -30
- Partials 114 120 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `71.11% <64.51%> (-16.89%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `75.00% <75.00%> (ø)` | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1663747...fb4cf3b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-932875652
Resolve conflicts pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-931932895
IMPORT 使用规范，请教下其他同学。
代码中不要出现中文注释。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur merged pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
ztelur merged pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (def72e0) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/d1930df3e910c5f948380c703fbbce4f49490d2d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1930df) will **increase** coverage by `2.45%`.
> The diff coverage is `69.95%`.
> :exclamation: Current head def72e0 differs from pull request most recent head 045a98b. Consider uploading reports for the commit 045a98b to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.93% 36.38% +2.45%
===========================================
Files 61 55 -6
Lines 3165 3262 +97
===========================================
+ Hits 1074 1187 +113
+ Misses 1979 1956 -23
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d1930df...045a98b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#discussion_r719962819
##########
File path: pkg/common/http/manager_test.go
##########
@@ -20,6 +20,7 @@ package http
import (
"bytes"
"fmt"
+ "github.com/apache/dubbo-go-pixiu/pkg/common/router/trie"
Review comment:
guy, move it.
##########
File path: pkg/common/router/router.go
##########
@@ -18,6 +18,7 @@
package router
import (
+ "github.com/apache/dubbo-go-pixiu/pkg/common/constant"
Review comment:
MOVE IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54319ff) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/9ea3feab604ae29ef166df8179a9e43b1b5dcb0f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ea3fea) will **increase** coverage by `2.30%`.
> The diff coverage is `69.66%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.45% +2.30%
===========================================
Files 62 56 -6
Lines 3321 3418 +97
===========================================
+ Hits 1101 1212 +111
+ Misses 2106 2085 -21
- Partials 114 121 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ea3fea...54319ff](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9941a73) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1663747a0648805768b7efec98b3318270ae680f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1663747) will **increase** coverage by `2.42%`.
> The diff coverage is `72.77%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.15% 35.57% +2.42%
===========================================
Files 62 56 -6
Lines 3321 3407 +86
===========================================
+ Hits 1101 1212 +111
+ Misses 2106 2075 -31
- Partials 114 120 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `75.00% <75.00%> (ø)` | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1663747...9941a73](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2081e44) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/8080a476f38363ea779a54793e228e97003770f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8080a47) will **increase** coverage by `2.33%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.14% 35.48% +2.33%
===========================================
Files 62 56 -6
Lines 3322 3416 +94
===========================================
+ Hits 1101 1212 +111
+ Misses 2107 2083 -24
- Partials 114 121 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `73.33% <67.74%> (-14.67%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.59% <71.59%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8080a47...2081e44](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#issuecomment-938476710
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#262](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45a9433) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/5bef4853016d8bfb0da4db715ccc5480cbcde7a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5bef485) will **increase** coverage by `2.45%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 33.93% 36.38% +2.45%
===========================================
Files 61 55 -6
Lines 3165 3262 +97
===========================================
+ Hits 1074 1187 +113
+ Misses 1979 1956 -23
- Partials 112 119 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <ø> (ø)` | |
| [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/router/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvcm91dGVyLmdv) | `74.46% <69.69%> (-13.54%)` | :arrow_down: |
| [pkg/common/router/trie/trie.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yb3V0ZXIvdHJpZS90cmllLmdv) | `71.18% <71.18%> (ø)` | |
| [pkg/model/router.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL3JvdXRlci5nbw==) | | |
| [pkg/model/match.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL21hdGNoLmdv) | | |
| [pkg/model/bootstrap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jvb3RzdHJhcC5nbw==) | | |
| [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | | |
| [pkg/model/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2h0dHAuZ28=) | | |
| [pkg/model/cluster.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2NsdXN0ZXIuZ28=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5bef485...45a9433](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on a change in pull request #262: add trie for route
Posted by GitBox <gi...@apache.org>.
mark4z commented on a change in pull request #262:
URL: https://github.com/apache/dubbo-go-pixiu/pull/262#discussion_r720780340
##########
File path: pkg/common/router/router.go
##########
@@ -54,23 +55,50 @@ func (rm *RouterCoordinator) Route(hc *http.HttpContext) (*model.RouteAction, er
return rm.activeConfig.Route(hc.Request)
}
+func getTrieKey(method string, path string, isPrefix bool) string {
+ if isPrefix {
+ return method + constant.PathSlash + path + constant.PathSlash + "**"
+ }
+ return method + constant.PathSlash + path
+}
+
// OnAddRouter add router
func (rm *RouterCoordinator) OnAddRouter(r *model.Router) {
+ //锁粒度 下期优化到 字典树node 级别
rm.rw.Lock()
defer rm.rw.Unlock()
+ if r.Match.Methods == nil {
+ r.Match.Methods = []string{constant.Get, constant.Put, constant.Delete, constant.Post}
+ }
+ isPrefix := r.Match.Prefix != ""
+ for _, method := range r.Match.Methods {
+ var key string
+ if isPrefix {
+ key = getTrieKey(method, r.Match.Prefix, isPrefix)
+ } else {
+ key = getTrieKey(method, r.Match.Path, isPrefix)
+ }
+ rm.activeConfig.RouteTrie.Put(key, r.Route)
+ }
Review comment:
resolve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org