You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/10/04 14:13:54 UTC
[I] CLI: Variables set should allow to set description [airflow]
eladkal opened a new issue, #34756:
URL: https://github.com/apache/airflow/issues/34756
### Body
The CLI:
`airflow variables set [-h] [-j] [-v] key VALUE`
https://airflow.apache.org/docs/apache-airflow/stable/cli-and-env-variables-ref.html#set_repeat1
Doesn't support adding description though column exists and we support it from Rest API:
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/post_variables
**The Task:**
Allow to set description from cli command
### Committer
- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CLI: Variables set should allow to set description [airflow]
Posted by "Zhenye-Na (via GitHub)" <gi...@apache.org>.
Zhenye-Na commented on issue #34756:
URL: https://github.com/apache/airflow/issues/34756#issuecomment-1749591515
> seems right. you should be able to test it with breeze https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst#id11
Cool, let me do it real quick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CLI: Variables set should allow to set description [airflow]
Posted by "starkhushi (via GitHub)" <gi...@apache.org>.
starkhushi commented on issue #34756:
URL: https://github.com/apache/airflow/issues/34756#issuecomment-1749360008
i wanted to solve this isuue .please assign me to solve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CLI: Variables set should allow to set description [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #34756:
URL: https://github.com/apache/airflow/issues/34756#issuecomment-1748619245
seems right.
you should be able to test it with breeze https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst#id11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CLI: Variables set should allow to set description [airflow]
Posted by "Zhenye-Na (via GitHub)" <gi...@apache.org>.
Zhenye-Na commented on issue #34756:
URL: https://github.com/apache/airflow/issues/34756#issuecomment-1748209835
Hi @eladkal ,
I am willing to take this issue and make a PR for this.
Before I made any changes, I think this issue is related to this code snippet https://github.com/apache/airflow/blob/99eeb84c820c8a380721e5d40f5917a01616b943/airflow/cli/commands/variable_command.py#L61-L66
In order to achieve this, I will need to update the following line
```python
Variable.set(args.key, args.value, serialize_json=args.json)
```
to something like this:
```python
Variable.set(args.key, args.value, args.description, serialize_json=args.json)
```
---
I am wondering if this approach looks good to you and please feel free to assign me to this issue.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CLI: Variables set should allow to set description [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #34756: CLI: Variables set should allow to set description
URL: https://github.com/apache/airflow/issues/34756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CLI: Variables set should allow to set description [airflow]
Posted by "Zhenye-Na (via GitHub)" <gi...@apache.org>.
Zhenye-Na commented on issue #34756:
URL: https://github.com/apache/airflow/issues/34756#issuecomment-1783653410
https://github.com/apache/airflow/pull/34791 is waiting for another approval, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] CLI: Variables set should allow to set description [airflow]
Posted by "Zhenye-Na (via GitHub)" <gi...@apache.org>.
Zhenye-Na commented on issue #34756:
URL: https://github.com/apache/airflow/issues/34756#issuecomment-1751920114
https://github.com/apache/airflow/pull/34791 is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org