You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/09 07:54:14 UTC

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #1737: fs/vfs: reuse file_dup2 directly in file_dup to fix segfault issue

liuguo09 opened a new pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737


   ## Summary
   Close the fd2 return by dup() would segment fault since filep->f_priv null access, while file_dup2 handle this rightly.
   
   ## Impact
   
   ## Testing
   Test and verify under sim
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] davids5 merged pull request #1737: fs/vfs: reuse file_dup2 directly in file_dup to fix segfault issue

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1737: fs/vfs: reuse file_dup2 directly in file_dup to fix segfault issue

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737#issuecomment-689523937


   LGTM, this bug is found and fixed in our LTP testing:
   https://github.com/linux-test-project/ltp


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #1737: fs/vfs: reuse file_dup2 directly in file_dup to fix segfault issue

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737#issuecomment-689485924


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org