You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/11/10 02:21:48 UTC

Review Request 40120: Refactored Docker registry puller.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40120/
-----------------------------------------------------------

Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

Changes:
  - Changes the getBlob API to accept Image name instead of a path.
  - Moved the intellegence of mapping remote path to registry client.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bc487d34e4087fa53452d63416d0f31e77060eb0 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 60239e44bafaa5a9b20977533cf55efd2a61d38f 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp fe6a90fe32364eec8ef923a000db19183603c338 

Diff: https://reviews.apache.org/r/40120/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese

Re: Review Request 40120: Refactored Docker registry puller.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40120/
-----------------------------------------------------------

(Updated Nov. 10, 2015, 1:38 a.m.)


Review request for mesos and Timothy Chen.


Changes
-------

minor fixes - function parameter names.


Repository: mesos


Description
-------

Changes:
  - Changes the getBlob API to accept Image name instead of a path.
  - Moved the intellegence of mapping remote path to registry client.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bc487d34e4087fa53452d63416d0f31e77060eb0 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 60239e44bafaa5a9b20977533cf55efd2a61d38f 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp fe6a90fe32364eec8ef923a000db19183603c338 

Diff: https://reviews.apache.org/r/40120/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese