[GitHub] [arrow-datafusion] liukun4515 edited a comment on issue #122: Implement DECIMAL type

[GitBox <gi...@apache.org>]

liukun4515 edited a comment on issue #122:
URL: https://github.com/apache/arrow-datafusion/issues/122#issuecomment-975036335


   - [ ] create external csv table with decimal data type in SQL parse and logical plan.
   - [x] decimal scalar #1393 
   - [x] create table and select column with decimal datatype https://github.com/apache/arrow-datafusion/pull/1431
   - [ ] support aggregate function(example min,max,count,sum)
      - [x] min/max https://github.com/apache/arrow-datafusion/pull/1407
      - [x] sum/avg https://github.com/apache/arrow-datafusion/pull/1408
      - [ ] sum/avg overflow checker https://github.com/apache/arrow-datafusion/issues/1460
      - [ ] count/ApproxDistinct/ArrayAgg
      - [x] coercion rule for aggregate function https://github.com/apache/arrow-datafusion/pull/1387
   - [x] support try_cast，cast : (1) support in arrow-rs https://github.com/apache/arrow-rs/issues/1043 (2) support in datafusion https://github.com/apache/arrow-datafusion/issues/1443
   - [x] support  comparison binary operation for decimal 
       - [x] comparison operation which implements in the datafusion. https://github.com/apache/arrow-datafusion/pull/1483
       - [x] use arrow-rs kernel to replace datafusion for =,!=,>,<...，lt. This should be implemented in the arrow-rs. we can refer https://github.com/apache/arrow-datafusion/pull/1163
       - [x] binary comparison coercion rules https://github.com/apache/arrow-datafusion/pull/1483
   - [x] support mathematics binary operation for decimal
       - [x] array with scalar value operation: https://github.com/apache/arrow-datafusion/issues/1513
       - [x] support decimal type for mathematics operation(+,-,*,/,%) https://github.com/apache/arrow-datafusion/pull/1554
   - [x] consolidate coercion rule for binary operation from this comments https://github.com/apache/arrow-datafusion/pull/1554#discussion_r786034055
   - [x] add sql level test: from https://github.com/apache/arrow-datafusion/pull/1483#pullrequestreview-853174771 comments.
   - [ ] support isdistinct/isnotdistinct for decimal data type https://github.com/apache/arrow-datafusion/issues/1590
   - [ ] SIMD in arrow-rs https://github.com/apache/arrow-rs/issues/1010
   - [ ] support expr evaluation (using in select, filter and other clause)
   - [x] support sort by decimal column https://github.com/apache/arrow-datafusion/issues/1522
   - [x] support hasher/group by decimal type  https://github.com/apache/arrow-datafusion/issues/1535
   - [ ] add document for promotion precision and scale https://github.com/apache/arrow-datafusion/issues/1461
   
   
   utils:
   - [ ] add from function to create a decimal array: https://github.com/apache/arrow-rs/issues/1009
   - [x] discussion about the result data type: https://github.com/apache/arrow-datafusion/issues/1418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org