You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/18 13:42:42 UTC
[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #12575: center the images on the overview page.
ThanoshanMV opened a new pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575
Fixes #12572
Hi @menghaoranss, I've aligned images to the center. Please check it.
Changes proposed in this pull request:
- Center the images on the overview page.
These are the screenshots I've taken after aligned the the below five images:
ecture](https://user-images.githubusercontent.com/48581379/133890551-30713b7d-1149-433b-ab82-ade2df284a11.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-922290831
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12575](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a9739) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e5b9782fc6bef276aa2263a0f168494fdd2e4b0c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5b9782) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #12575 +/- ##
=========================================
Coverage 63.43% 63.44%
Complexity 1309 1309
=========================================
Files 2414 2414
Lines 36802 36803 +1
Branches 6391 6391
=========================================
+ Hits 23346 23350 +4
+ Misses 11559 11556 -3
Partials 1897 1897
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tsql/rdl/resource/AlterResourceBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL3Jlc291cmNlL0FsdGVyUmVzb3VyY2VCYWNrZW5kSGFuZGxlci5qYXZh) | `90.62% <0.00%> (ø)` | |
| [...atus/compute/service/ComputeNodeStatusService.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS9zdGF0dXMvY29tcHV0ZS9zZXJ2aWNlL0NvbXB1dGVOb2RlU3RhdHVzU2VydmljZS5qYXZh) | `100.00% <0.00%> (ø)` | |
| [...he/shardingsphere/mode/persist/PersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9QZXJzaXN0U2VydmljZS5qYXZh) | | |
| [...ngsphere/mode/persist/node/SchemaMetadataNode.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9ub2RlL1NjaGVtYU1ldGFkYXRhTm9kZS5qYXZh) | | |
| [...persist/service/impl/PropertiesPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9zZXJ2aWNlL2ltcGwvUHJvcGVydGllc1BlcnNpc3RTZXJ2aWNlLmphdmE=) | | |
| [...e/shardingsphere/mode/persist/node/GlobalNode.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9ub2RlL0dsb2JhbE5vZGUuamF2YQ==) | | |
| [.../persist/service/SchemaMetaDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9zZXJ2aWNlL1NjaGVtYU1ldGFEYXRhUGVyc2lzdFNlcnZpY2UuamF2YQ==) | | |
| [...persist/service/impl/SchemaRulePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9zZXJ2aWNlL2ltcGwvU2NoZW1hUnVsZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | | |
| [...persist/service/impl/DataSourcePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9zZXJ2aWNlL2ltcGwvRGF0YVNvdXJjZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | | |
| [...persist/service/impl/GlobalRulePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcGVyc2lzdC9zZXJ2aWNlL2ltcGwvR2xvYmFsUnVsZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | | |
| ... and [10 more](https://codecov.io/gh/apache/shardingsphere/pull/12575/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e5b9782...68a9739](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-922438301
I moved the RegisterCenter to the right of the image:
Please let me know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-922438301
I moved the RegisterCenter to the right of the image:
Please let me know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-922489475
Hi @tristaZero 😃 I'll start participating in #6478.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu edited a comment on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-924522715
I can merge it, and let UED partner to adjust it for position in center only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-922470748
Hey @ThanoshanMV , how are you doing? 👋
I am curious whether you are interested in proofreading [SQLServer](#6478)?
Since you have been familiar with ANTLR, I presume you're the best one for that issue. But if you want to try others, I can find something new for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-922470748
Hey @ThanoshanMV , how are you doing? 👋
I am curious whether you are interested in proofreading SQLServer (#6478)?
Since you have been familiar with ANTLR, I presume you're the best one for that issue. But if you want to try others, I can find something new for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-924601274
Sure, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-924522715
I can merge it, and let UED partner to adjust it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #12575: center the images on the overview page.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12575:
URL: https://github.com/apache/shardingsphere/pull/12575#issuecomment-922290831
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12575](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0462ef6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e5b9782fc6bef276aa2263a0f168494fdd2e4b0c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5b9782) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #12575 +/- ##
=========================================
Coverage 63.43% 63.43%
Complexity 1309 1309
=========================================
Files 2414 2414
Lines 36802 36802
Branches 6391 6391
=========================================
Hits 23346 23346
Misses 11559 11559
Partials 1897 1897
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e5b9782...0462ef6](https://codecov.io/gh/apache/shardingsphere/pull/12575?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org