[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

[GitBox <gi...@apache.org>]

AlexanderVasiljev commented on a change in pull request #2036:
URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508234861



##########
File path: drivers/serial/serial.c
##########
@@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected)
 void uart_reset_sem(FAR uart_dev_t *dev)
 {
   nxsem_reset(&dev->xmitsem,  0);
-  nxsem_reset(&dev->recvsem,  0);
+  nxsem_reset(&dev->recvsem,  1);

Review comment:
       No. It doesn't hurt. It is checked in the receive interrupt. After closing the driver no interrupt will happen.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org