[GitHub] [accumulo] keith-turner commented on a diff in pull request #3604: Removes split,bulk, and compaction code from tserver

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3604:
URL: https://github.com/apache/accumulo/pull/3604#discussion_r1263940921


##########
server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java:
##########
@@ -759,13 +759,16 @@ private void fetchScans() {
 
   private void fetchCompactions() {
     ServerContext context = getContext();
+
     for (String server : context.instanceOperations().getTabletServers()) {
       final HostAndPort parsedServer = HostAndPort.fromString(server);
       Client tserver = null;
       try {
         tserver = ThriftUtil.getClient(ThriftClientTypes.TABLET_SERVER, parsedServer, context);
-        var compacts = tserver.getActiveCompactions(null, context.rpcCreds());
-        allCompactions.put(parsedServer, new CompactionStats(compacts));
+        // ELASTICITY_TODO tservers no longer have any compaction information, following code was

Review Comment:
   > I left a comment on a similar issue - but we should look at tracking property, metrics and status info changes so that we can map previous capabilities -> new. Maybe its start a section in the release notes?
   
   One way to do that would be to open specific issues in the GH elasticity project.  Something like this "Change X needs user facing documentation".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org