You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/05 18:39:52 UTC
[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18664: Fix python micro-site table of content bugs
ys2843 opened a new pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664
## Description ##
fix #16349, the table of content on Python microsite overlaps with footer when scrolling down to the bottom.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
### Changes ###
- [ ] Fixed Python site table of content overlapping with footer
## Comments ##
- Preview: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/getting-started/gluon_from_experiment_to_deployment.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-653923786
@mxnet-label-bot update [Website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-656388836
> @ys2843 any update?
Q1: Is it expected to disappear when you scroll into the footer?
+ I think hide the toc is an acceptable fix without touching many other css and js.
Q2: Autodiff header isn't working?
+ Fixed the underlying JS logic in the follow up commit, please verify in preview. Thanks.
Q3: Moreover clicking on auto-diff brings back the shift anchor tag issue
+ Fixed, other anchor shift issues please verify this PR #18674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-656411928
@mxnet-bot run ci [ unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-653937370
Jenkins CI successfully triggered : [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] aaronmarkham merged pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
aaronmarkham merged pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-653923786
@mxnet-label-bot add [Website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-653923727
Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, miscellaneous, edge, unix-cpu, website, windows-cpu, centos-gpu, unix-gpu, clang, windows-gpu, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-656411928
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-656823093
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-655881954
@ys2843 any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-653937357
@mxnet-bot run ci [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-656911391
unix-gpu fails with test_npx_batch_norm here as you can see here: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-18664/6/pipeline
Searching on apache/incubator-mxnet issues: https://github.com/apache/incubator-mxnet/issues/18687
This got fixed by a PR: #18688
So you'll have to rebase this PR on master [so that your branch contains the commit which fixed it]
To rebase
1. Add upstream
```
git remote add upstream https://github.com/apache/incubator-mxnet
```
2. Sync fork master with upstream master
```
git checkout master
git fetch upstream master
git merge upstream/master
git push origin master
```
3. Sync feature branch
```
git checkout <branchname>
git rebase master
git push -f origin <branchname>
```
Other alternative to rebase would be to merge it [this results in a new commit which says "Merge..." and thus doesn't require a "force push"
```
git checkout <branchname>
git merge master
git push origin <branchname>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-656411967
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18664: Fix python micro-site table of content bugs
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18664:
URL: https://github.com/apache/incubator-mxnet/pull/18664#issuecomment-653923786
@mxnet-label-bot add [Website, pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org