You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robert Greig (JIRA)" <qp...@incubator.apache.org> on 2006/12/13 19:25:20 UTC
[jira] Created: (QPID-183) Session.unsubscribe does not handle
invalid arguments correctly
Session.unsubscribe does not handle invalid arguments correctly
---------------------------------------------------------------
Key: QPID-183
URL: http://issues.apache.org/jira/browse/QPID-183
Project: Qpid
Issue Type: Bug
Components: JMS Compliance
Reporter: Robert Greig
Trying to unsubscribe from a durable subscription to which you are not already subscribed should result in an InvalidDestinationException being thrown. This is currently not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (QPID-183) Session.unsubscribe does not handle
invalid arguments correctly
Posted by "Robert Greig (JIRA)" <qp...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/QPID-183?page=all ]
Robert Greig reassigned QPID-183:
---------------------------------
Assignee: Robert Greig
Rob Godfrey is working on this issue.
> Session.unsubscribe does not handle invalid arguments correctly
> ---------------------------------------------------------------
>
> Key: QPID-183
> URL: http://issues.apache.org/jira/browse/QPID-183
> Project: Qpid
> Issue Type: Bug
> Components: JMS Compliance
> Reporter: Robert Greig
> Assigned To: Robert Greig
>
> Trying to unsubscribe from a durable subscription to which you are not already subscribed should result in an InvalidDestinationException being thrown. This is currently not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (QPID-183) Session.unsubscribe does not handle
invalid arguments correctly
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey closed QPID-183.
----------------------------
> Session.unsubscribe does not handle invalid arguments correctly
> ---------------------------------------------------------------
>
> Key: QPID-183
> URL: https://issues.apache.org/jira/browse/QPID-183
> Project: Qpid
> Issue Type: Bug
> Components: JMS Compliance
> Reporter: Robert Greig
> Assignee: Robert Greig
> Fix For: M2
>
> Attachments: qpid-183.patch, qpid-183.patch
>
>
> Trying to unsubscribe from a durable subscription to which you are not already subscribed should result in an InvalidDestinationException being thrown. This is currently not happening.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-183) Session.unsubscribe does not handle
invalid arguments correctly
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/QPID-183?page=all ]
Rob Godfrey updated QPID-183:
-----------------------------
Attachment: qpid-183.patch
The previous fix covered only the case where the durable subscription had been creted within the same client instance (i.e. did not account for client restarting). The following patch has a comprehensive solution which deals with the restarting case.
A protocol change is necessary this API to be met correctly, and a provisional protocol change is included in this patch.
> Session.unsubscribe does not handle invalid arguments correctly
> ---------------------------------------------------------------
>
> Key: QPID-183
> URL: http://issues.apache.org/jira/browse/QPID-183
> Project: Qpid
> Issue Type: Bug
> Components: JMS Compliance
> Reporter: Robert Greig
> Assigned To: Robert Greig
> Attachments: qpid-183.patch, qpid-183.patch
>
>
> Trying to unsubscribe from a durable subscription to which you are not already subscribed should result in an InvalidDestinationException being thrown. This is currently not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (QPID-183) Session.unsubscribe does not handle
invalid arguments correctly
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey resolved QPID-183.
------------------------------
Resolution: Fixed
Fix Version/s: M2
> Session.unsubscribe does not handle invalid arguments correctly
> ---------------------------------------------------------------
>
> Key: QPID-183
> URL: https://issues.apache.org/jira/browse/QPID-183
> Project: Qpid
> Issue Type: Bug
> Components: JMS Compliance
> Reporter: Robert Greig
> Assignee: Robert Greig
> Fix For: M2
>
> Attachments: qpid-183.patch, qpid-183.patch
>
>
> Trying to unsubscribe from a durable subscription to which you are not already subscribed should result in an InvalidDestinationException being thrown. This is currently not happening.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-183) Session.unsubscribe does not handle
invalid arguments correctly
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/QPID-183?page=all ]
Rob Godfrey updated QPID-183:
-----------------------------
Attachment: qpid-183.patch
added a map to AMQSession to keep track of subscriptions
also provide unit test
> Session.unsubscribe does not handle invalid arguments correctly
> ---------------------------------------------------------------
>
> Key: QPID-183
> URL: http://issues.apache.org/jira/browse/QPID-183
> Project: Qpid
> Issue Type: Bug
> Components: JMS Compliance
> Reporter: Robert Greig
> Assigned To: Robert Greig
> Attachments: qpid-183.patch
>
>
> Trying to unsubscribe from a durable subscription to which you are not already subscribed should result in an InvalidDestinationException being thrown. This is currently not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (QPID-183) Session.unsubscribe does not handle
invalid arguments correctly
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/QPID-183?page=comments#action_12458488 ]
Rajith Attapattu commented on QPID-183:
---------------------------------------
Robert,
I think the local map is a better implementation as I pointed out in my previous email.
I also provided a fix for this using Queue.declare with passive true that will notify if the queue is there.
However when u commit Godfrey's patch please remove that code as I feel a local map is more fast and efficient and I certainly prefer that.
Regards,
Rajith
> Session.unsubscribe does not handle invalid arguments correctly
> ---------------------------------------------------------------
>
> Key: QPID-183
> URL: http://issues.apache.org/jira/browse/QPID-183
> Project: Qpid
> Issue Type: Bug
> Components: JMS Compliance
> Reporter: Robert Greig
> Assigned To: Robert Greig
> Attachments: qpid-183.patch
>
>
> Trying to unsubscribe from a durable subscription to which you are not already subscribed should result in an InvalidDestinationException being thrown. This is currently not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira