You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "T Jake Luciani (JIRA)" <ji...@apache.org> on 2012/09/04 15:43:07 UTC
[jira] [Created] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
T Jake Luciani created CASSANDRA-4609:
-----------------------------------------
Summary: Add thrift transport factory impl to cassandra-cli
Key: CASSANDRA-4609
URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
Project: Cassandra
Issue Type: Sub-task
Reporter: T Jake Luciani
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459911#comment-13459911 ]
Jason Brown commented on CASSANDRA-4609:
----------------------------------------
Alex, Pavel and I discussed offline, and it seems best to be able to pass the name of transport factory as a command line arg, --transport_factory.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455817#comment-13455817 ]
T Jake Luciani commented on CASSANDRA-4609:
-------------------------------------------
Yeah, I think it should be generic
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-4609:
--------------------------------------
Parent Issue: CASSANDRA-4239 (was: CASSANDRA-4607)
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463755#comment-13463755 ]
Jason Brown commented on CASSANDRA-4609:
----------------------------------------
file 4609_cass1.1.patch should apply to the 1.2 branch, as well.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch, 4609_cass1.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Brown updated CASSANDRA-4609:
-----------------------------------
Attachment: (was: 0001-CASSANDRA-4609-Add-thrift-transport-factory-impl-to-.patch)
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch, 4609_cass1.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Brown updated CASSANDRA-4609:
-----------------------------------
Attachment: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
add thrift transport factory support to cassandra-cli. Modified the client to optionally use the client encryptions (thrift ssl) and to use the new ITransportFactory design.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4609) Add thrift transport
factory impl to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462492#comment-13462492 ]
Jason Brown edited comment on CASSANDRA-4609 at 9/25/12 5:47 PM:
-----------------------------------------------------------------
After discussing offline with Pavel, a more generic implementation, based upon using the TTransportFactory class as a base is submitted here. Further, to release the configurable transport factory with the 1.1 release, we're removing the dependency upon thrift SSL integration until 1.2 (see CASSANDRA-4239). I'll create the client-side thrift SSL integration as part of finalizing CASSANDRA-4239.
was (Author: jasobrown):
After discussing offline with Pavel, a more generic implementation, based upon using the TTransportFactory class as a base. Further, to release the configurable transport factory with the 1.1 release, we're removing the dependency upon thrift SSL integration until 1.2 (see CASSANDRA-4239). I'll create the client-side thrift SSL integration as part of finalizing CASSANDRA-4239.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch, 4609_cass1.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-4609:
---------------------------------------
Reviewer: xedin
Fix Version/s: 1.1.6
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Alex Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459933#comment-13459933 ]
Alex Liu commented on CASSANDRA-4609:
-------------------------------------
that works as well.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4609:
--------------------------------------
Priority: Minor (was: Major)
Fix Version/s: (was: 1.1.6)
1.2.0 beta 2
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Priority: Minor
> Fix For: 1.2.0 beta 2
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch, 4609_cass1.1.patch, CASSANDRA-4609-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Brown updated CASSANDRA-4609:
-----------------------------------
Attachment: 0001-CASSANDRA-4609-Add-thrift-transport-factory-impl-to-.patch
After discussing offline with Pavel, a more generic implementation, based upon using the TTransportFactory class as a base. Further, to release the configurable transport factory with the 1.1 release, we're removing the dependency upon thrift SSL integration until 1.2 (see CASSANDRA-4239). I'll create the client-side thrift SSL integration as part of finalizing CASSANDRA-4239.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0001-CASSANDRA-4609-Add-thrift-transport-factory-impl-to-.patch, 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-4609:
---------------------------------------
Attachment: CASSANDRA-4609-v2.patch
attaching v2 to show how I want transport-factories to be done for CLI, what do you think Jason?
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch, 4609_cass1.1.patch, CASSANDRA-4609-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469154#comment-13469154 ]
Jason Brown commented on CASSANDRA-4609:
----------------------------------------
Yes, looks a little simpler than mine (which used the CliTransportFactory as an intermediary factory). LGTM, +1.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch, 4609_cass1.1.patch, CASSANDRA-4609-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457464#comment-13457464 ]
Jason Brown commented on CASSANDRA-4609:
----------------------------------------
Sorry for the delay. Ok, part of the reason there's a little bit of a dance going on here is that it wasn't clear to me that the ticket name 'Add thrift transport factory' didn't map 1-to-1 with the existing ITransportFactory interface. Hence, that's why thew submitted code may look a little contorted trying to shoehorn that interface into a more general high level factory for thrift transports. I'll rework this patch, as well as CASSANDRA-4608/CASSANDRA-4662.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Alex Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459718#comment-13459718 ]
Alex Liu commented on CASSANDRA-4609:
-------------------------------------
Jason, Can you add a ITransportFactory configuration option in cassandra.yaml, so that the cassandra-cli can use any plugin TransportFactory.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4609) Add thrift transport factory impl
to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Brown updated CASSANDRA-4609:
-----------------------------------
Attachment: 4609_cass1.1.patch
(attaching correct file this time...)
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch, 4609_cass1.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455705#comment-13455705 ]
Pavel Yaskevich commented on CASSANDRA-4609:
--------------------------------------------
This doesn't look like what I had in mind, the reason to have transport factory is to remove all the branching we already have - e.g. if (sessionState.framed) or socket considerations, and let pluggable transport factory to generate the correct transport in one line.
I think it should be done in a way that allows users to pass --transport-factory as a parameter to the cassandra-cli script or if it wasn't given use some default factory. So actually if you want SSL enabled sockets, you can pass it something like TThriftSSLFactory which on getTransport() would generate SSL TSocket and return it as TTransport without checking anything directly in CliMain. What do you think, Jake?
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Jason Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Brown reassigned CASSANDRA-4609:
--------------------------------------
Assignee: Jason Brown
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory
impl to cassandra-cli
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455836#comment-13455836 ]
Pavel Yaskevich commented on CASSANDRA-4609:
--------------------------------------------
We want to have factory in generic form because we are planing to support various transports which should not depend on any external checks for framing etc. on the user side.
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
> Key: CASSANDRA-4609
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: Jason Brown
> Fix For: 1.1.6
>
> Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira