[GitHub] [hive] zabetak commented on a diff in pull request #3559: HIVE-26496,Improvement to fetch operator to scan only delete_delta fo…

[GitBox <gi...@apache.org>]

zabetak commented on code in PR #3559:
URL: https://github.com/apache/hive/pull/3559#discussion_r973212714


##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java:
##########
@@ -104,7 +103,15 @@ public OrcSplit(Path path, Object fileId, long offset, long length, String[] hos
     this.isOriginal = isOriginal;
     this.hasBase = hasBase;
     this.rootDir = rootDir;
-    this.deltas.addAll(filterDeltasByBucketId(deltas, AcidUtils.parseBucketId(path)));
+    int bucketId = AcidUtils.parseBucketId(path);

Review Comment:
   @difin @deniskuzZ 
   The local variable hides the instance variable; probably is was intentional but it is quite confusing; especially for someone that's gonna debug this code in the future. A comment/explanation would definitely help.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org