You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/10 18:48:51 UTC
[jira] [Commented] (SHINDIG-1774) init.js blindly assumes that the
JS servlet feature URL is the last script tag defined
[ https://issues.apache.org/jira/browse/SHINDIG-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272483#comment-13272483 ]
jiraposter@reviews.apache.org commented on SHINDIG-1774:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5087/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Summary
-------
init.js assumes the feature URL for the JS servlet is the last script tag when this will not always be the case.
This addresses bug SHINDIG-1774.
https://issues.apache.org/jira/browse/SHINDIG-1774
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/init.js 1336780
Diff: https://reviews.apache.org/r/5087/diff
Testing
-------
All tests pass.
Local testing done.
Thanks,
Mike
> init.js blindly assumes that the JS servlet feature URL is the last script tag defined
> --------------------------------------------------------------------------------------
>
> Key: SHINDIG-1774
> URL: https://issues.apache.org/jira/browse/SHINDIG-1774
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta1
> Reporter: Michael May
> Priority: Trivial
> Labels: javascript
> Attachments: init.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> init.js assumes the feature URL for the JS servlet is the last script tag when this will not always be the case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira