You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2023/10/03 07:32:43 UTC

Re: [PR] arch: simplify ARCH_PERF_EVENTS related code [nuttx]

raiden00pl commented on PR #10828:
URL: https://github.com/apache/nuttx/pull/10828#issuecomment-1744365777

   @acassis we could place a warning like this in all files that depend on high resolution perf:
   
   ```
   #if defined(CONFIG_ARCH_HAVE_PERF_EVENTS) && !defined(CONFIG_ARCH_PERF_EVENTS)
   #  warning blah blah blah
   #endif
   ```
   
   but this will pollute the build output for archs that have broken hardware perf. 
   The solution with auto-selection of ARCH_PERF_EVENTS has the advantage that users must intentionally turn off this flag if their arch has a broken perf, and in such a case we can assume that users know exactly what they are doing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org