You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (JIRA)" <ji...@apache.org> on 2013/05/03 06:06:16 UTC
[jira] [Commented] (TS-1825) TSPortDescriptorAccept() does not use
its TSCont contp parameter
[ https://issues.apache.org/jira/browse/TS-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648172#comment-13648172 ]
James Peach commented on TS-1825:
---------------------------------
Upgrading to blocker. This really breaks the API.
> TSPortDescriptorAccept() does not use its TSCont contp parameter
> ----------------------------------------------------------------
>
> Key: TS-1825
> URL: https://issues.apache.org/jira/browse/TS-1825
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Reporter: Leif Hedstrom
> Priority: Blocker
> Fix For: 3.3.3
>
>
> This looks odd:
> {code}
> TSReturnCode
> TSPortDescriptorAccept(TSPortDescriptor descp, TSCont contp)
> {
> HttpProxyPort * port = (HttpProxyPort *)descp;
> return start_HttpProxyPort(*port, 0 /* nthreads */) ? TS_SUCCESS : TS_ERROR;
> }
> {code}
> Assuming that (as per the IRC discussions) TSPortDescriptAccept() should work something similar to TSNetAccept, shouldn't it be using the contp for callbacks?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira