[GitHub] [arrow] danepitkin commented on pull request #34980: GH-34979: [Python] Create a base class for Table and RecordBatch

["danepitkin (via GitHub)" <gi...@apache.org>]

danepitkin commented on PR #34980:
URL: https://github.com/apache/arrow/pull/34980#issuecomment-1500597881

   The first commit moves the `take()` method from the individual `Table` and `RecordBatch` classes to the base class `_Table`. The docstring is shared, but ends up being a bit confusing. I think the best path forward is to refactor this and create an internal method on the `_Table` class e.g. `_Table._take()` and override it in the subclasses with a subclass-specific docstring.
   
   E.g.
   ```
   cdef class Table(_Table):
       def take(self, object indices):
       """ <Class-specific docstring> """
           return self._take(indices)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org