You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/10 07:07:51 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request #257: Minor Improvements:
arturobernalg opened a new pull request #257:
URL: https://github.com/apache/httpcomponents-core/pull/257
* Unnecessary boxing
* Unnecessary unboxing
* complete javadoc
* inline variable
* Change PosixParser to DefaultParser
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #257: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #257:
URL: https://github.com/apache/httpcomponents-core/pull/257#issuecomment-776939079
@arturobernalg Would it be OK for you to put javadoc changes into a separate commit or PR? I suspect there are many more places where javadocs need some work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #257: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #257:
URL: https://github.com/apache/httpcomponents-core/pull/257#issuecomment-776965246
@arturobernalg I would not bother. Just raise a PR when ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #257: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #257:
URL: https://github.com/apache/httpcomponents-core/pull/257#issuecomment-776964462
> @arturobernalg Would it be OK for you to put javadoc changes into a separate commit or PR? I suspect there are many more places where javadocs need some work.
Hi @ok2c . No problem. Do I need to create a Jira for the javadoc ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #257: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #257:
URL: https://github.com/apache/httpcomponents-core/pull/257#issuecomment-777208200
> @arturobernalg I would not bother. Just raise a PR when ready.
Hi @ok2c I've reverted the changes regarding the javaDoc. When i finish i'll provide another PR just only with javaDoc
TY
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #257: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #257:
URL: https://github.com/apache/httpcomponents-core/pull/257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org