You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/02/14 16:03:00 UTC

Re: [PR] [Transform] Improve symbolic variable handling in FuseOps [tvm]

Lunderberg commented on PR #16450:
URL: https://github.com/apache/tvm/pull/16450#issuecomment-1944132898

   Rebased onto main to resolve conflicts.
   
   For long-term, I think I agree that it would be cleaner and more general-purpose to have the functionality separated out into three distinct passes:
   
   1. `FuseOps`, with the first commit in this PR to preserve symbolic variables in the `ret_struct_info`.
   2. A not-yet-existing `HoistCommonSubexpressions`, which would recognize that a symbolic variable is always used within a specific expression, and would hoist it to the calling scope.
   3. Applying the `RemoveUnusedParameters` to remove the no-longer-required `R.shape` param.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org