You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by Massimo Manghi <ma...@unipr.it> on 2011/11/18 10:49:00 UTC
Scripts output oddity
I realized yesterday night that tests in rivet-namespace failed
because of a spurious carriage return showed up in the channel
output buffer.
I verified the same character appears also with code in trunk but
it cannot be a change in Tcl.
Rivet scripts are made out of the concatenation of the BeforeScript,
plus the script referenced in the URL, plus the AfterScript.
The unexpected CR comes just after the output of the URL script, so
either I accept it as is or I have to debug the Tcl channel internal
buffer. Suggestions before I dive into this?
-- Massimo
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: Scripts output oddity *SOLVED*
Posted by Massimo Manghi <ma...@unipr.it>.
the last broken tests have been fixed and now the branch is set up to
be
reintegrated into trunk. Some tests have been reworked, I hope
I didn't turn them into self fulfilling tests, but I think they needed
some massage...
I will allow one more week before merging it back into the main
development, so that anyone curious to see it can compile and test it.
I will check the docs, they certainly need some work to account for
the latest changes.
-- Massimo
On 20.11.2011 16:17, Karl Lehenbauer wrote:
> Good work, Massimo. Thank you.
>
> On Nov 20, 2011, at 4:32 AM, Massimo Manghi wrote:
>
>> I solved this problem with a quick review of the svn logs pertaining
>> the
>> code involved in the Rivet channel handling and rvt template parsing
>>
>> It was instant clear that none had changed the code in years
>> and so I turned my attention to the rvt files in the test suite.
>> It turned out they were supposed to have the final eol stripped off,
>> whereas my editor reintroduced the eol when I changed the command
>> names into their fully qualified form.
>> The problem was tiny, the reason why and when an eol slid into those
>> files is rather obscured in the darkness of svn, since there is no
>> sign of modification in the logs.
>>
>> Only virtualhost.test seems to be in a bad state with a substantial
>> mismatch between actual and expected outputs
>>
>> -- Massimo
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: Scripts output oddity *SOLVED*
Posted by Karl Lehenbauer <ka...@gmail.com>.
Good work, Massimo. Thank you.
On Nov 20, 2011, at 4:32 AM, Massimo Manghi wrote:
> I solved this problem with a quick review of the svn logs pertaining the
> code involved in the Rivet channel handling and rvt template parsing
>
> It was instant clear that none had changed the code in years
> and so I turned my attention to the rvt files in the test suite.
> It turned out they were supposed to have the final eol stripped off,
> whereas my editor reintroduced the eol when I changed the command
> names into their fully qualified form.
> The problem was tiny, the reason why and when an eol slid into those
> files is rather obscured in the darkness of svn, since there is no
> sign of modification in the logs.
>
> Only virtualhost.test seems to be in a bad state with a substantial
> mismatch between actual and expected outputs
>
> -- Massimo
>
>
> On 18.11.2011 11:49, Massimo Manghi wrote:
>> I realized yesterday night that tests in rivet-namespace failed
>> because of a spurious carriage return showed up in the channel
>> output buffer.
>>
>> I verified the same character appears also with code in trunk but
>> it cannot be a change in Tcl.
>>
>> Rivet scripts are made out of the concatenation of the BeforeScript,
>> plus the script referenced in the URL, plus the AfterScript.
>>
>> The unexpected CR comes just after the output of the URL script, so
>> either I accept it as is or I have to debug the Tcl channel internal
>> buffer. Suggestions before I dive into this?
>>
>> -- Massimo
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
>> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org
Re: Scripts output oddity *SOLVED*
Posted by Massimo Manghi <ma...@unipr.it>.
I solved this problem with a quick review of the svn logs pertaining
the
code involved in the Rivet channel handling and rvt template parsing
It was instant clear that none had changed the code in years
and so I turned my attention to the rvt files in the test suite.
It turned out they were supposed to have the final eol stripped off,
whereas my editor reintroduced the eol when I changed the command
names into their fully qualified form.
The problem was tiny, the reason why and when an eol slid into those
files is rather obscured in the darkness of svn, since there is no
sign of modification in the logs.
Only virtualhost.test seems to be in a bad state with a substantial
mismatch between actual and expected outputs
-- Massimo
On 18.11.2011 11:49, Massimo Manghi wrote:
> I realized yesterday night that tests in rivet-namespace failed
> because of a spurious carriage return showed up in the channel
> output buffer.
>
> I verified the same character appears also with code in trunk but
> it cannot be a change in Tcl.
>
> Rivet scripts are made out of the concatenation of the BeforeScript,
> plus the script referenced in the URL, plus the AfterScript.
>
> The unexpected CR comes just after the output of the URL script, so
> either I accept it as is or I have to debug the Tcl channel internal
> buffer. Suggestions before I dive into this?
>
> -- Massimo
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org