[jira] [Work logged] (LANG-1665) Modify Tuple equals to take BigDecimal comparison

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-1665?focusedWorklogId=626611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626611 ]

ASF GitHub Bot logged work on LANG-1665:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/21 12:46
            Start Date: 22/Jul/21 12:46
    Worklog Time Spent: 10m 
      Work Description: garydgregory commented on a change in pull request #780:
URL: https://github.com/apache/commons-lang/pull/780#discussion_r674752466



##########
File path: src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
##########
@@ -403,6 +404,20 @@ public void testEquals() {
         assertTrue(ObjectUtils.equals(FOO, FOO), "ObjectUtils.equals(\"foo\", \"foo\") returned false");
     }
 
+    @Test
+    public void TestEqualsOrCompareBigDecimal(){
+        assertTrue(ObjectUtils.equalsOrCompareBigDecimal(null,null));

Review comment:
       Fix formatting: space after comma.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 626611)
    Remaining Estimate: 0h
            Time Spent: 10m

> Modify Tuple equals to take BigDecimal comparison
> -------------------------------------------------
>
>                 Key: LANG-1665
>                 URL: https://issues.apache.org/jira/browse/LANG-1665
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.tuple.*
>    Affects Versions: 3.12.0
>            Reporter: Chikashi Toyoshima
>            Priority: Trivial
>             Fix For: 3.12.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I understand that this would be a bit controversial. Imhp as possibly ignorable suggestion, it'd be more helpful if the Tuple supports BgDecimal numeric equality rather than simply checking object.
>  
> In a particular case, you may want to check if a collection of pairs contain a certain pair which includes BigDecimal values. Then to check object equality is maybe just right or not. But in many cases, I assume that numeric comparison would be more demanded such as following simple example. 
> {code:java}
> Set<Pair<String, BigDecimal>> someCollection = getPairs(); 
> someCollection.contains(Pair.of("foo", BigDecimal.valueOf(100))); 
> {code}
>  
> I created the PR. Please take a look. I'm happy to whichever it is accepted or not receiving feedback.
> [https://github.com/apache/commons-lang/pull/780]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)