[GitHub] [accumulo] keith-turner commented on a change in pull request #1005: Fix #949 handle WAL failure to prevent stuck Accumulo

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1005: Fix #949 handle WAL failure to prevent stuck Accumulo
URL: https://github.com/apache/accumulo/pull/1005#discussion_r263453971
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
 ##########
 @@ -308,11 +300,44 @@ public void run() {
                 log.warn("Failed to delete a WAL that failed to open", e);
               }
             }
+            
+            continue;
+          }
+          
+          String fileName = alog.getFileName();
+          log.debug("Created next WAL " + fileName);
+          
+          try {
+            tserver.addNewLogMarker(alog);
+          } catch (Exception t) {
+            log.error("Failed to add new WAL marker for " + fileName, t);
+              
+            try {
+              alog.close();
 
 Review comment:
   It would be really nice to add a comment here that the file is intentionally not being deleted and why that is. Could also put the issue number in the comment. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services