You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "frazar (via GitHub)" <gi...@apache.org> on 2023/08/21 14:38:01 UTC
[GitHub] [airflow] frazar opened a new pull request, #33583: Fix broken link to the "UPDATING.md" file
frazar opened a new pull request, #33583:
URL: https://github.com/apache/airflow/pull/33583
The "UPDATING.md" file has been removed in v2.3.0 with commit 5b9bd9954bbc6ed68c217761d581f3af46269af9, and therefore it does not exist on the `main` branch. Instead, link to the file's latest version (_i.e._, v2.2.5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33583: Fix broken link to the "UPDATING.md" file
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33583:
URL: https://github.com/apache/airflow/pull/33583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33583: Fix broken link to the "UPDATING.md" file
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #33583:
URL: https://github.com/apache/airflow/pull/33583#issuecomment-1686458015
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33583: Fix broken link to the "UPDATING.md" file
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33583:
URL: https://github.com/apache/airflow/pull/33583#discussion_r1300319490
##########
docs/apache-airflow/deprecated-rest-api-ref.rst:
##########
@@ -21,7 +21,7 @@ Deprecated REST API
.. warning::
This REST API is deprecated since version 2.0. Please consider using the :doc:`stable REST API <stable-rest-api-ref>`.
- For more information on migration, see `UPDATING.md <https://github.com/apache/airflow/blob/main/UPDATING.md>`_
+ For more information on migration, see `UPDATING.md <https://github.com/apache/airflow/blob/2.2.5/UPDATING.md>`_
Review Comment:
This is probably better link:
`https://airflow.apache.org/docs/apache-airflow/stable/howto/upgrading-from-1-10/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33583: Fix broken link to the "UPDATING.md" file
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #33583:
URL: https://github.com/apache/airflow/pull/33583#issuecomment-1689844615
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frazar commented on a diff in pull request #33583: Fix broken link to the "UPDATING.md" file
Posted by "frazar (via GitHub)" <gi...@apache.org>.
frazar commented on code in PR #33583:
URL: https://github.com/apache/airflow/pull/33583#discussion_r1301493524
##########
docs/apache-airflow/deprecated-rest-api-ref.rst:
##########
@@ -21,7 +21,7 @@ Deprecated REST API
.. warning::
This REST API is deprecated since version 2.0. Please consider using the :doc:`stable REST API <stable-rest-api-ref>`.
- For more information on migration, see `UPDATING.md <https://github.com/apache/airflow/blob/main/UPDATING.md>`_
+ For more information on migration, see `UPDATING.md <https://github.com/apache/airflow/blob/2.2.5/UPDATING.md>`_
Review Comment:
I see, replaced the link as suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org