You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2006/06/22 23:28:29 UTC
[jira] Créée: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
-------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-47
URL: http://issues.apache.org/jira/browse/OFBIZ-47
Project: The Open For Business Project
Type: Bug
Components: order
Versions: SVN trunk
Environment: svn 7817
Reporter: Jacques Le Roux
Priority: Blocker
Fix For: SVN trunk
Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by Alexandre Gomes <al...@gmail.com>.
Jacques,
I confirmed your problem but now with the latest svn version things
seem to be OK.
What I saw happening was that the orders were being produced with
0.0 value on the price and that caused the invoice to have 0.0 as the
total price.
Alexandre
On 6/26/06, Jacques Le Roux (JIRA) <ji...@apache.org> wrote:
> [ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417876 ]
>
> Jacques Le Roux commented on OFBIZ-47:
> --------------------------------------
>
> Si,
>
> Isn't the 1st comment enough ? I may add comments if necessary, please let me know.
>
> Jacques
>
> > createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> > -------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: OFBIZ-47
> > URL: http://issues.apache.org/jira/browse/OFBIZ-47
> > Project: The Open For Business Project
> > Type: Bug
>
> > Components: order
> > Versions: SVN trunk
> > Environment: svn 7817
> > Reporter: Jacques Le Roux
> > Assignee: Si Chen
> > Priority: Blocker
> > Fix For: SVN trunk
> > Attachments: 06-06-22 CommDivZ.patch
> >
> > Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> > Jacques
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
Re: [jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by Jacques Le Roux <ja...@les7arts.com>.
> On 6/23/06, Jacques Le Roux (JIRA) <ji...@apache.org> wrote:
>
> > But actually it seems strange to approve order and ship before the paiement
is received, don't you think so ?
>
> Here in Italy, lots of people prefer to pay in cash on delivery of
> their merchandise.
>
> --
> David N. Welton
Yes David,
But if I'm not wrong there is a paiment type for this kind of thing (COD,
Collect on Delivery) and I was speaking about "Mail Check/Money Order". For me
the distinction is that when you use COD there is a surcharge for the service.
Jacques
Re: [jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by David Welton <da...@gmail.com>.
On 6/23/06, Jacques Le Roux (JIRA) <ji...@apache.org> wrote:
> But actually it seems strange to approve order and ship before the paiement is received, don't you think so ?
Here in Italy, lots of people prefer to pay in cash on delivery of
their merchandise.
--
David N. Welton
- http://www.dedasys.com/davidw/
Linux, Open Source Consulting
- http://www.dedasys.com/
[jira] Updated: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Vinay Agarwal (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=all ]
Vinay Agarwal updated OFBIZ-47:
-------------------------------
Attachment: 06-06-22 CommDivZ.patch
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417449 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
ASA someone is able to commit this patch, this issue may be closed. Even if the commision problem remains. The best would be to create a new issue about this specific problem, Vinay ?
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417448 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
Vinay,
This may be a problem in the future, but it's OK for me for now. I just needed to be able to quick ship an order with a money order paiement received.
Thanks
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Vinay Agarwal (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417482 ]
Vinay Agarwal commented on OFBIZ-47:
------------------------------------
Jacques,
Are the invoices being created and all the payments being applied correct? I didn't think it was doing it even if there was no external error.
Vinay
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417557 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
Thanks Vinay,
But actually it seems strange to approve order and ship before the paiement is received, don't you think so ?
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=all ]
Si Chen closed OFBIZ-47:
------------------------
Resolution: Fixed
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12418079 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
Si,
I think so, it's not blocking anymore.
Jacques
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=all ]
Si Chen reassigned OFBIZ-47:
----------------------------
Assign To: Si Chen
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417517 ]
Si Chen commented on OFBIZ-47:
------------------------------
Why is it trying to create a payment application against no invoice? How is the payment application being called? I will take a look at the patch, but I think that's something we should address.
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Vinay Agarwal (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417486 ]
Vinay Agarwal commented on OFBIZ-47:
------------------------------------
Jacques,
If you just want to get going, I suggest you use the following sequence in order manager
-approve order
-quick ship
-receive payment
I know this sequence creates correct invoices and payment even without the patch.
Vinay
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Vinay Agarwal (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417394 ]
Vinay Agarwal commented on OFBIZ-47:
------------------------------------
Another interesting message from the log
258766 (http-0.0.0.0-8443-Processor2) [ Log.java:103:WARN ] Create Payment Application: Amount to apply [36.76] is greater than the outstanding amount [0.0] of the invoice [10030]. Creating Payment Application for outstanding amount [0.0] instead.
I am not really sure what does the receive payment do before the shipment, it doesn't sound as if it is doing what we expect it to do.
Vinay
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417563 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
OK Vinay,
Will take a longuer look at it tomorrow. See also my response to David W. on dev ML, please
Thanks
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417876 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
Si,
Isn't the 1st comment enough ? I may add comments if necessary, please let me know.
Jacques
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417854 ]
Si Chen commented on OFBIZ-47:
------------------------------
Vinay,
I committed your patch but created a new error ui label to display the right message for this error. Please do not take shortcuts with things like error messages--you could cost the next person to work on your code a lot of grief by using the wrong message.
Si
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12418064 ]
Si Chen commented on OFBIZ-47:
------------------------------
So may I close this now?
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417855 ]
Si Chen commented on OFBIZ-47:
------------------------------
Jacques,
I agree with you. Why is this service being called at all? Can you tell me about what the steps are that led to it?
Si
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Vinay Agarwal (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417389 ]
Vinay Agarwal commented on OFBIZ-47:
------------------------------------
Jacques,
I can reproduce the problem. The problem is caused by createCommissionInvoices receiving an invoiceId that doesn't yet exist and hence determines zero amount. I have added a patch that returns success if it gets invoice with no invoice items that will solve your problem. It returns success if the invoiceId it receives returns zero amount (which is the case when the invoice doesn't exist).
But it would not calculate commission correctly since it would simply ignore the invoice. Somehow createCommissionInvoices needs to be called after the invoice is created (and stored). Currently it is being called by a seca on createPaymentApplication service on "commit" event and it seems to work correctly when the item is shipped first and then the payment is applied (but not the other way).
Help!
Regards,
Vinay
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a
"BigInteger divide by zero" in case of Quick Ship Order and "Mail
Check/Money Order" paiement
Posted by "Vinay Agarwal (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417561 ]
Vinay Agarwal commented on OFBIZ-47:
------------------------------------
Jacques,
That sequence actually makes sense. A sale is recognized (GAAP) when the item is shipped. Therefore, an invoice can only be generated after that. Any payment received before invoice generation is simply an advance. Once the invoice is generated, a payment can be applied to that invoice.
Also, from order application, in OrderTypeData.xml, you can see the valid status change sequences as follows:
<StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_PROCESSING" transitionName="Process Order"/>
<StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_APPROVED" transitionName="Approve Order"/>
<StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_REJECTED" transitionName="Reject Order"/>
<StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
<StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_APPROVED" transitionName="Approve Order"/>
<StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_REJECTED" transitionName="Reject Order"/>
<StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
<StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_SENT" transitionName="Send Order"/>
<StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_PROCESSING" transitionName="Hold Order"/>
<StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_COMPLETED" transitionName="Complete Order"/>
<StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
<StatusValidChange condition="" statusId="ORDER_SENT" statusIdTo="ORDER_COMPLETED" transitionName="Order Completed"/>
<StatusValidChange condition="" statusId="ORDER_SENT" statusIdTo="ORDER_CANCELLED" transitionName="Order Cancelled"/>
Regards,
Vinay
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417667 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
Vinay,
I agree that this may be a solution. However Si's remark may also be of interest before patching and closing this issue.
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commenté: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417916 ]
Jacques Le Roux commented on OFBIZ-47:
--------------------------------------
To be clear I put this comment from ALexandre Gomes on the dev ML
______________________________________________________________________________________________________________
Jacques,
I confirmed your problem but now with the latest svn version things seem to be OK. What I saw happening was that the orders were being produced with 0.0 value on the price and that caused the invoice to have 0.0 as the total price.
Alexandre
____________________________________________________________________________________________________
I agree Alexandre but why orders were being being produced with 0.0 value on the price after I had received the cash paiement ? When I made the same order but with a CC paiement the problem did not appear. So I guess that there is something unclear here, don't you think so ?
Sorry I have no time to look at it further.
Jacques
Jacques
> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-47
> URL: http://issues.apache.org/jira/browse/OFBIZ-47
> Project: The Open For Business Project
> Type: Bug
> Components: order
> Versions: SVN trunk
> Environment: svn 7817
> Reporter: Jacques Le Roux
> Assignee: Si Chen
> Priority: Blocker
> Fix For: SVN trunk
> Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira