You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/04/06 03:24:02 UTC
[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21251
Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable
......................................................................
[rpc-test] make RpcPendingConnectionsMetric more stable
I noticed that on very fast machines the RpcPendingConnectionsMetric
scenario would rarely fail (~1 time per 500 runs) because the
sock_diag() netlink facility seemingly reported stale data, i.e.
reported one connection was pending while the only attempted connection
had already been accepted by the server and even closed by the client.
With this test no flakiness has been observed in more than 50K runs
of the scenario.
Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 23 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/21251/1
--
To view, visit http://gerrit.cloudera.org:8080/21251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa
Gerrit-Change-Number: 21251
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21251 )
Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa
Gerrit-Change-Number: 21251
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2024 14:31:46 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21251 )
Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable
......................................................................
Patch Set 1: Verified+1
I verified it fixes the flakiness at least on SLES15 SP4.
--
To view, visit http://gerrit.cloudera.org:8080/21251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa
Gerrit-Change-Number: 21251
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Apr 2024 16:13:25 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21251 )
Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa
Gerrit-Change-Number: 21251
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 23:24:15 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21251 )
Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable
......................................................................
[rpc-test] make RpcPendingConnectionsMetric more stable
I noticed that on very fast machines the RpcPendingConnectionsMetric
scenario would rarely fail (~1 time per 500 runs) because the
sock_diag() netlink facility seemingly reported stale data, i.e.
reported one connection was pending while the only attempted connection
had already been accepted by the server and even closed by the client.
With this test no flakiness has been observed in more than 50K runs
of the scenario.
Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa
Reviewed-on: http://gerrit.cloudera.org:8080/21251
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 23 insertions(+), 9 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa
Gerrit-Change-Number: 21251
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>