You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/08/08 04:20:05 UTC
Review Request 24487: OOZIE-1913 Devise a way to turn off SLA alerts for
bundle/coordinator flexibly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1913
https://issues.apache.org/jira/browse/OOZIE-1913
Repository: oozie-git
Description
-------
See Jira
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3
client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 5d3fc62
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1
core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 5d3b6af
core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java cd26e07
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 42a0968
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81
core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237
core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071
core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java fd21c45
core/src/main/resources/oozie-default.xml ebceaa7
core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11
Diff: https://reviews.apache.org/r/24487/diff/
Testing
-------
ongoing
Thanks,
Mona Chitnis
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA alerts for
bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review50101
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment87652>
this has been removed
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment87653>
this has been removed. The action ids/dates range is read as argument for option -suspendalerts itself
- Mona Chitnis
On Aug. 8, 2014, 2:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 2:20 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 5d3fc62
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 5d3b6af
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java cd26e07
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 42a0968
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81
> core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java fd21c45
> core/src/main/resources/oozie-default.xml ebceaa7
> core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> ongoing
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA alerts for
bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review50269
-----------------------------------------------------------
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/24487/#comment87956>
this change is part of OOZIE-1932 and will remove it in next patch version
- Mona Chitnis
On Aug. 8, 2014, 2:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 2:20 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 5d3fc62
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 5d3b6af
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java cd26e07
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 42a0968
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81
> core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java fd21c45
> core/src/main/resources/oozie-default.xml ebceaa7
> core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> ongoing
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review52110
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment90856>
changing this to hasArgs=false as its not mandatory
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment90853>
this got left behind. thanks
- Mona Chitnis
On Aug. 14, 2014, 11:13 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 11:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 2f0a45c
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 5d3fc62
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 5d3b6af
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java cd26e07
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 42a0968
> core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java 8296a6c
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 3fbd092
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81
> core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java fd21c45
> core/src/main/resources/oozie-default.xml ebceaa7
> core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java fedf4a8
> core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java a39efe3
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java fa26935
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5a35fdb
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 210c99e
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> unit tests added, e-2-e test with CLI command done
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Oct. 17, 2014, 7:38 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/coord/CoordUtils.java, lines 146-147
> > <https://reviews.apache.org/r/24487/diff/4/?file=692718#file692718line146>
> >
> > What happens to other commands?
other commands calling this util method - kill and rerun. in both cases, we should allow superset of action and ability to skip over if all actions in the range are not there.
> On Oct. 17, 2014, 7:38 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/coord/CoordUtils.java, line 258
> > <https://reviews.apache.org/r/24487/diff/4/?file=692718#file692718line258>
> >
> > private
referenced in another class too
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review57158
-----------------------------------------------------------
On Sept. 17, 2014, 6:59 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 6:59 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java f3ffd1f
> client/src/main/java/org/apache/oozie/client/OozieClient.java d6ff2d0
> client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 801ad7e
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4b393c8
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java cc5596b
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 71a9ab4
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 070cee5
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java de78ab7
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 05b7a62
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 0aee0e4
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 2c9e00e
> core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java ee1085a
> core/src/main/java/org/apache/oozie/service/EventHandlerService.java 244c048
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 11835ed
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java eb699e6
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 396661a
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java de4f865
> core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/BundleEnableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/CoordDisableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/CoordEnableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java cdf8b73
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 7c2620c
> core/src/main/resources/oozie-default.xml 6a91dc6
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java f13e48f
> core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java db9c594
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java db3f6eb
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> unit tests added, e-2-e test with CLI command done
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review57158
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment97634>
Either suspend-sla-alert or suspendslaalert. Standard commands don't use camel case for commandline options. For eg: curl (hyphenated), java (no separator).
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment97646>
coordinators
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/24487/#comment97650>
UpdateSLA
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/24487/#comment97653>
Rest API should have suspend=true and resume=true. Should not have suspend=false to imply that resume=true. Or better would be to have action=suspend or resume which is more cleaner and follows other REST APIs.
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java
<https://reviews.apache.org/r/24487/#comment97664>
GET_COORD_JOBS_FOR_BUNDLE_BY_APPNAME
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/24487/#comment97665>
We should not be changing this
core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/24487/#comment97668>
What happens to other commands?
core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/24487/#comment97669>
Why remove javadoc for a public method? Make it private if it is just going to be internal helper
core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/24487/#comment97670>
private
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/24487/#comment97682>
enclosing {} for if block. Other places too
core/src/main/java/org/apache/oozie/sla/service/SLAService.java
<https://reviews.apache.org/r/24487/#comment97666>
Running periodic SLA check
core/src/main/java/org/apache/oozie/sla/service/SLAService.java
<https://reviews.apache.org/r/24487/#comment97667>
Separate methods for suspend and resume sla alerts
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/24487/#comment97639>
disable
- Rohini Palaniswamy
On Sept. 17, 2014, 6:59 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 6:59 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java f3ffd1f
> client/src/main/java/org/apache/oozie/client/OozieClient.java d6ff2d0
> client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 801ad7e
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4b393c8
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java cc5596b
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 71a9ab4
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 070cee5
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java de78ab7
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 05b7a62
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 0aee0e4
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 2c9e00e
> core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java ee1085a
> core/src/main/java/org/apache/oozie/service/EventHandlerService.java 244c048
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 11835ed
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java eb699e6
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 396661a
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java de4f865
> core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/BundleEnableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/CoordDisableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/CoordEnableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java cdf8b73
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 7c2620c
> core/src/main/resources/oozie-default.xml 6a91dc6
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java f13e48f
> core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java db9c594
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java db3f6eb
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> unit tests added, e-2-e test with CLI command done
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review61210
-----------------------------------------------------------
Core logic looks great, few comments.
1. We are only supporting coord_name with bundle, it will be nice if we can support coord_id as well.
2. I guess we are not displaying sla alert information anywhere, it will be hard for user to know which action is disabled. I think it will be useful if we can display sla enable/disable information with some command and in Oozie UI SLA Tab.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment102732>
Has args should be true. SLA_DISABLE_ALERT need jobId.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment102733>
Has args should be true.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment102734>
Has args should be true.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment102735>
Is this used?
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment102736>
Why optionsGroups? They should be added as option, like run, dryrun.
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/24487/#comment102737>
Why not json responce, All oozie webservice responce is json.
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/24487/#comment102740>
Not used anywhere.
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/24487/#comment104216>
Should include ignore status
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/24487/#comment104217>
Should include ignore status
core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/24487/#comment104226>
Will this work if job freqency is in different time zone?
core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/24487/#comment104220>
why name cabs?
core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java
<https://reviews.apache.org/r/24487/#comment104199>
Why? I don't think it's being used anywhere.
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
<https://reviews.apache.org/r/24487/#comment104201>
Not supported in v0
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
<https://reviews.apache.org/r/24487/#comment104202>
Not supported in v0
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
<https://reviews.apache.org/r/24487/#comment104203>
Not supported in v0
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java
<https://reviews.apache.org/r/24487/#comment104207>
This code used in three function, please move it to one sun-function().
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java
<https://reviews.apache.org/r/24487/#comment104251>
Since we have diffent command for different job_type, this logic can move to <jobType>XCommand.
core/src/main/java/org/apache/oozie/sla/BundleChangeSlaXCommand.java
<https://reviews.apache.org/r/24487/#comment104228>
BundleChangeSlaXCommand and CoordChangeSlaXCommand does same thing, in that case we can have only one class ChangeSlaXCommand.
core/src/main/java/org/apache/oozie/sla/BundleChangeSlaXCommand.java
<https://reviews.apache.org/r/24487/#comment102743>
Why requeue?
core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java
<https://reviews.apache.org/r/24487/#comment104230>
we can merge BundleDisableSlaAlertsXCommand and CoordDisableSlaAlertsXCommand to DisableSlaAlertsXCommand.
core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java
<https://reviews.apache.org/r/24487/#comment102744>
Do u need to load bundle bean? I guess we are not using it.
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/24487/#comment104231>
Is this used anywhere?
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
<https://reviews.apache.org/r/24487/#comment104232>
why sleep of 5 min. If you need it add it to specific testcase, it will slowdown the testcase execution.
- Purshotam Shah
On Oct. 20, 2014, 11:20 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 11:20 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9c2d14b
> client/src/main/java/org/apache/oozie/client/OozieClient.java 5e53a18
> client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 801ad7e
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4cc6606
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 759e643
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 2362084
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 070cee5
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java de78ab7
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 05b7a62
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java e6ab09b
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 4bccef4
> core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java ee1085a
> core/src/main/java/org/apache/oozie/service/EventHandlerService.java 244c048
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java c94d1e2
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java b160b46
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 8dc9608
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java da81b49
> core/src/main/java/org/apache/oozie/sla/BundleChangeSlaXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/BundleEnableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/CoordChangeSlaXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/CoordDisableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/CoordEnableSlaAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 188144e
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 7c2620c
> core/src/main/resources/oozie-default.xml 26eb7e0
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java f13e48f
> core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java db3f6eb
> core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java b8b2405
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> unit tests added, e-2-e test with CLI command done
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 11:20 p.m.)
Review request for oozie.
Changes
-------
review comments addressed. minor changes required in 2 unit tests and will update that next
Bugs: OOZIE-1913
https://issues.apache.org/jira/browse/OOZIE-1913
Repository: oozie-git
Description
-------
See Jira
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9c2d14b
client/src/main/java/org/apache/oozie/client/OozieClient.java 5e53a18
client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 801ad7e
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4cc6606
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 759e643
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 2362084
core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 070cee5
core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java de78ab7
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 05b7a62
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java e6ab09b
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 4bccef4
core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java ee1085a
core/src/main/java/org/apache/oozie/service/EventHandlerService.java 244c048
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java c94d1e2
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java b160b46
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 8dc9608
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java da81b49
core/src/main/java/org/apache/oozie/sla/BundleChangeSlaXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/BundleEnableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/CoordChangeSlaXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/CoordDisableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/CoordEnableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea
core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 188144e
core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826
core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc
core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 7c2620c
core/src/main/resources/oozie-default.xml 26eb7e0
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java f13e48f
core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d
core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java db3f6eb
core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java b8b2405
Diff: https://reviews.apache.org/r/24487/diff/
Testing
-------
unit tests added, e-2-e test with CLI command done
Thanks,
Mona Chitnis
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/
-----------------------------------------------------------
(Updated Sept. 17, 2014, 6:59 p.m.)
Review request for oozie.
Changes
-------
Addressd Puru's comment to make separate bundle/coord disable/enable commands.
Bugs: OOZIE-1913
https://issues.apache.org/jira/browse/OOZIE-1913
Repository: oozie-git
Description
-------
See Jira
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java f3ffd1f
client/src/main/java/org/apache/oozie/client/OozieClient.java d6ff2d0
client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 801ad7e
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4b393c8
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java cc5596b
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 71a9ab4
core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 070cee5
core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java de78ab7
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 05b7a62
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 0aee0e4
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 2c9e00e
core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java ee1085a
core/src/main/java/org/apache/oozie/service/EventHandlerService.java 244c048
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 11835ed
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java eb699e6
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 396661a
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java de4f865
core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/BundleEnableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/CoordDisableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/CoordEnableSlaAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea
core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java cdf8b73
core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826
core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc
core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 7c2620c
core/src/main/resources/oozie-default.xml 6a91dc6
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java f13e48f
core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d
core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java db9c594
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java db3f6eb
Diff: https://reviews.apache.org/r/24487/diff/
Testing
-------
unit tests added, e-2-e test with CLI command done
Thanks,
Mona Chitnis
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review52265
-----------------------------------------------------------
Extra line changes (false ones) in BundleSubmitX and SubmitTransitionX I'll remove in final/next version
- Mona Chitnis
On Sept. 4, 2014, 1:05 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 1:05 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 79a9b68
> client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2
> client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 801ad7e
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4b393c8
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java cc5596b
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 14fd74c
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 070cee5
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java d479086
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java a13fe83
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 0aee0e4
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 25953bf
> core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 7a688b1
> core/src/main/java/org/apache/oozie/service/EventHandlerService.java 244c048
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java f651d5c
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 508538d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 6427989
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java b7b9be9
> core/src/main/java/org/apache/oozie/sla/SLAAlertsXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java cdf8b73
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 7c2620c
> core/src/main/resources/oozie-default.xml 3a957d0
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java f13e48f
> core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java db9c594
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5f51b22
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java db3f6eb
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> unit tests added, e-2-e test with CLI command done
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 1:05 a.m.)
Review request for oozie.
Changes
-------
updated patch with review comments
Bugs: OOZIE-1913
https://issues.apache.org/jira/browse/OOZIE-1913
Repository: oozie-git
Description
-------
See Jira
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 79a9b68
client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2
client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 801ad7e
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 4b393c8
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java cc5596b
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 14fd74c
core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 070cee5
core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java d479086
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java a13fe83
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 0aee0e4
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 25953bf
core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 7a688b1
core/src/main/java/org/apache/oozie/service/EventHandlerService.java 244c048
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java f651d5c
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 508538d
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 6427989
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java b7b9be9
core/src/main/java/org/apache/oozie/sla/SLAAlertsXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea
core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java cdf8b73
core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826
core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc
core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 7c2620c
core/src/main/resources/oozie-default.xml 3a957d0
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java f13e48f
core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d
core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java db9c594
core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5f51b22
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java db3f6eb
Diff: https://reviews.apache.org/r/24487/diff/
Testing
-------
unit tests added, e-2-e test with CLI command done
Thanks,
Mona Chitnis
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Aug. 29, 2014, 4:52 p.m., Purshotam Shah wrote:
> > client/src/main/java/org/apache/oozie/client/OozieClient.java, line 152
> > <https://reviews.apache.org/r/24487/diff/2/?file=660982#file660982line152>
> >
> > Do you need to say new (newshouldend ) ?
> >
> > When we specify end time for coord, we just say endtime=<>, better to keep same convention.
Its consistent with the current SLA terminology - should-start, should-end. I dont see the major benefit of deviating from this terminology. Also endtime=<> and should-end are dealing with different values, former specifies date and latter specifies the number of minutes relative to a nominal time for sla purposes.
> On Aug. 29, 2014, 4:52 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java, line 91
> > <https://reviews.apache.org/r/24487/diff/2/?file=660987#file660987line91>
> >
> > We are reading from same conf and setting to same conf. why??
dont remember the rationale now. removing
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review51473
-----------------------------------------------------------
On Aug. 14, 2014, 11:13 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 11:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 2f0a45c
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 5d3fc62
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 5d3b6af
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java cd26e07
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 42a0968
> core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java 8296a6c
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 3fbd092
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81
> core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java fd21c45
> core/src/main/resources/oozie-default.xml ebceaa7
> core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java fedf4a8
> core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java a39efe3
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java fa26935
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5a35fdb
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 210c99e
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> unit tests added, e-2-e test with CLI command done
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/#review51473
-----------------------------------------------------------
I think we need to change the approch a bit.
We need to support slaEnable and slaDisable as command. We might need to add CoordSlaEnableXCoomand, CoordSlaDisableXCoomand, BundleSlaEnableXCoomand and BundleSlaEnableXCoomand.
Can you please make that change, it will easy to review after that.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment89820>
Option suspend = new Option(SLA_ALERT_SUSPEND_OPTION, true, "option suspends sla alerts for given jobs");
This is not required as SLA_ALERT_SUSPEND_OPTION need args, if it's null apache CLI will throw error.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/24487/#comment89821>
ID is not needed, refer JIRA for more info.
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/24487/#comment89822>
Do you need to say new (newshouldend ) ?
When we specify end time for coord, we just say endtime=<>, better to keep same convention.
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java
<https://reviews.apache.org/r/24487/#comment89825>
Thanks for fixing this.
core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java
<https://reviews.apache.org/r/24487/#comment89836>
We are reading from same conf and setting to same conf. why??
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/24487/#comment89828>
if in {}
core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/24487/#comment89833>
if and for should be in {}
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/24487/#comment89834>
I think this not part of this patch. Please revert.
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/24487/#comment89835>
Why?
- Purshotam Shah
On Aug. 14, 2014, 11:13 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24487/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 11:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1913
> https://issues.apache.org/jira/browse/OOZIE-1913
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3
> client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
> client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 2f0a45c
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 5d3fc62
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1
> core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 5d3b6af
> core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java cd26e07
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 42a0968
> core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java 8296a6c
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 3fbd092
> core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81
> core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5
> core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237
> core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df
> core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
> core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071
> core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
> core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java fd21c45
> core/src/main/resources/oozie-default.xml ebceaa7
> core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java fedf4a8
> core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java a39efe3
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java fa26935
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5a35fdb
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 210c99e
>
> Diff: https://reviews.apache.org/r/24487/diff/
>
>
> Testing
> -------
>
> unit tests added, e-2-e test with CLI command done
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 24487: OOZIE-1913 Devise a way to turn off SLA
alerts for bundle/coordinator flexibly
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24487/
-----------------------------------------------------------
(Updated Aug. 14, 2014, 11:13 p.m.)
Review request for oozie.
Changes
-------
updated patch to include unit tests, and fixes uncovered in the process
Bugs: OOZIE-1913
https://issues.apache.org/jira/browse/OOZIE-1913
Repository: oozie-git
Description
-------
See Jira
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3
client/src/main/java/org/apache/oozie/client/OozieClient.java b468186
client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java 2f0a45c
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 5d3fc62
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1
core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java 5d3b6af
core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java cd26e07
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 42a0968
core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java 8296a6c
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 3fbd092
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81
core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5
core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237
core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325
core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071
core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329
core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java fd21c45
core/src/main/resources/oozie-default.xml ebceaa7
core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java fedf4a8
core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java a39efe3
core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java fa26935
core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5a35fdb
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 210c99e
Diff: https://reviews.apache.org/r/24487/diff/
Testing (updated)
-------
unit tests added, e-2-e test with CLI command done
Thanks,
Mona Chitnis