You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/14 09:34:30 UTC
Review Request 57591: Alert Definition "Last Changed" field is shown
incorrect if alert wan't triggered any time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57591/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: AMBARI-20441
https://issues.apache.org/jira/browse/AMBARI-20441
Repository: ambari
Description
-------
* Go to Alert Definition details page for Definition with NONE status (e.g. "NameNode Heap Usage (Daily)")
*AR* "Last Changed" is shown as "Jan 01 1970"
*ER* This field should be empty
Diffs
-----
ambari-web/app/models/alerts/alert_definition.js b55ef1b
ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js f987c52
ambari-web/test/models/alerts/alert_definition_test.js 3d8b62d
Diff: https://reviews.apache.org/r/57591/diff/1/
Testing
-------
20562 passing (21s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57591: Alert Definition "Last Changed" field is
shown incorrect if alert wan't triggered any time
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57591/#review168876
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On March 14, 2017, 9:34 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57591/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 9:34 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: AMBARI-20441
> https://issues.apache.org/jira/browse/AMBARI-20441
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Go to Alert Definition details page for Definition with NONE status (e.g. "NameNode Heap Usage (Daily)")
>
> *AR* "Last Changed" is shown as "Jan 01 1970"
> *ER* This field should be empty
>
>
> Diffs
> -----
>
> ambari-web/app/models/alerts/alert_definition.js b55ef1b
> ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js f987c52
> ambari-web/test/models/alerts/alert_definition_test.js 3d8b62d
>
>
> Diff: https://reviews.apache.org/r/57591/diff/1/
>
>
> Testing
> -------
>
> 20562 passing (21s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>