You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Doug Cutting <cu...@apache.org> on 2005/05/06 20:00:32 UTC
Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene:
index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java
search/PhrasePrefixQuery.java search/PhraseQuery.java search/TermQuery.java
dnaber@apache.org wrote:
> don't declare Exceptions that are never thrown; remove an unused variable
When these are implementing a pubic interface or abstract method I think
it is good to keep the exception declaration, as it is a part of the
interface. That way, if an exception needs to be thrown in the future,
the developer knows what types are permitted.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene: index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java search/PhrasePrefixQuery.java search/PhraseQuery.java search/TermQuery.java
Posted by Daniel Naber <lu...@danielnaber.de>.
On Friday 06 May 2005 20:00, Doug Cutting wrote:
> When these are implementing a pubic interface or abstract method I think
> it is good to keep the exception declaration, as it is a part of the
> interface.
Yes, I'm aware of that. All my changes (unless I made a mistake) only
affected private or final methods or methods inside inner private classes.
Regards
Daniel
--
http://www.danielnaber.de
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org