You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/01 21:30:05 UTC
[kudu-CR](branch-1.5.x) gradle: also inject mkdir when modifying gradlew
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7940
Change subject: gradle: also inject mkdir when modifying gradlew
......................................................................
gradle: also inject mkdir when modifying gradlew
Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.
Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Reviewed-on: http://gerrit.cloudera.org:8080/7939
Reviewed-by: Grant Henke <gr...@gmail.com>
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit c8ad6668e8ebe17ff12c70cc77a8ed351595d1e3)
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/7940/1
--
To view, visit http://gerrit.cloudera.org:8080/7940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR](branch-1.5.x) gradle: also inject mkdir when modifying gradlew
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: gradle: also inject mkdir when modifying gradlew
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) gradle: also inject mkdir when modifying gradlew
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: gradle: also inject mkdir when modifying gradlew
......................................................................
gradle: also inject mkdir when modifying gradlew
Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.
Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Reviewed-on: http://gerrit.cloudera.org:8080/7939
Reviewed-by: Grant Henke <gr...@gmail.com>
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit c8ad6668e8ebe17ff12c70cc77a8ed351595d1e3)
Reviewed-on: http://gerrit.cloudera.org:8080/7940
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins