[GitHub] [superset] john-bodley commented on a diff in pull request #24649: chore/docs: Update Rockset dependency

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24649:
URL: https://github.com/apache/superset/pull/24649#discussion_r1260011039


##########
setup.py:
##########
@@ -178,7 +178,7 @@ def get_git_sha() -> str:
         "trino": ["trino>=0.324.0"],
         "prophet": ["prophet>=1.0.1, <1.1", "pystan<3.0"],
         "redshift": ["sqlalchemy-redshift>=0.8.1, < 0.9"],
-        "rockset": ["rockset>=0.8.10, <0.9"],
+        "rockset": ["rockset-sqlalchemy>=0.0.1"],

Review Comment:
   @gadhagod would you mind including an upper bound (exclusive of) the next major version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org