You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/12 19:54:48 UTC

[GitHub] [incubator-nuttx-testing] v01d opened a new pull request #62: make bash abort on error

v01d opened a new pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62


   ## Summary
   
   This fixes one of the issues I found with CI. The call on NuttX workflow is like:
   
   <pre>
   testbuild.sh
   ccache -s
   </pre>
   
   and even if `testbuild.sh` failed, since `ccache` didn't, this did not fail the test. 
   
   ## Impact
   
   Fixes CI
   
   ## Testing
   
   Not possible, will have to do once merged.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-testing] v01d commented on pull request #62: make bash abort on error

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62#issuecomment-691537837


   If this PR works, the CI should fail everywhere (not only on mac) =b


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-testing] btashton commented on pull request #62: make bash abort on error

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62#issuecomment-691538163






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-testing] btashton commented on pull request #62: make bash abort on error

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62#issuecomment-691538163


   It's bash calling bash all the way down :1st_place_medal:   Thanks for tracking that down.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-testing] btashton merged pull request #62: make bash abort on error

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-testing] v01d commented on pull request #62: make bash abort on error

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62#issuecomment-691537837






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-testing] v01d commented on pull request #62: make bash abort on error

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62#issuecomment-691537837






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-testing] btashton commented on pull request #62: make bash abort on error

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #62:
URL: https://github.com/apache/incubator-nuttx-testing/pull/62#issuecomment-691538163






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org