You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/18 23:57:10 UTC
[GitHub] [beam] lostluck commented on a change in pull request #17045: [BEAM-10976] Bundle finalization: E2E support
lostluck commented on a change in pull request #17045:
URL: https://github.com/apache/beam/pull/17045#discussion_r830408454
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/v1/v1.pb.go
##########
@@ -212,18 +212,19 @@ const (
Type_CONTEXT Type_Special = 2
Type_TYPE Type_Special = 3
// Beam
- Type_EVENTTIME Type_Special = 10
- Type_WINDOW Type_Special = 22
- Type_KV Type_Special = 11
- Type_COGBK Type_Special = 13
- Type_WINDOWEDVALUE Type_Special = 14
- Type_T Type_Special = 15
- Type_U Type_Special = 16
- Type_V Type_Special = 17
- Type_W Type_Special = 18
- Type_X Type_Special = 19
- Type_Y Type_Special = 20
- Type_Z Type_Special = 21
+ Type_EVENTTIME Type_Special = 10
+ Type_WINDOW Type_Special = 22
+ Type_KV Type_Special = 11
+ Type_COGBK Type_Special = 13
+ Type_WINDOWEDVALUE Type_Special = 14
+ Type_BUNDLEFINALIZATION Type_Special = 23
Review comment:
Never manually update Generated Proto files:
You'll need to add the type to here, and regen the file. https://github.com/apache/beam/blob/5cfff1ac54b7446b0627f58a1e9cd5f9472d64c2/sdks/go/pkg/beam/core/runtime/graphx/v1/v1.proto#L113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org