You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/06/21 14:23:48 UTC
[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH opened a new pull request #29: Add support for tee-supplicant loadable plugins
DemesneGH opened a new pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29
Hi @mssun
The loadable plugins framework is a new feature in OPTEE 3.13.0. It allows TA actively invoke a command defined in normal world plugins (which are compiled as .so dynlibs).See [this commit](https://github.com/OP-TEE/optee_client/commit/1e91cc797f72261fb03e7c2ce30944ff613ac07e).
In this commit I've updated:
1. In`optee-teec` `optee-utee` and `optee-utee-sys`:Wrap for related apis;
2. Add a new example `supp_plugin` for tee-supplicant plugins.The work logic is `host->TA->plugin`.Plugins are identified by uuid.
Best Regards,
Yuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] mssun merged pull request #29: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
mssun merged pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] mssun merged pull request #29: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
mssun merged pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH commented on a change in pull request #29: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
DemesneGH commented on a change in pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29#discussion_r656819230
##########
File path: examples/supp_plugin/plugin/plugin_static.rs
##########
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#[no_mangle]
+pub static mut plugin_method: PluginMethod = PluginMethod {
Review comment:
After removing the `mut`, this error occurs:
```
error[E0277]: `*mut u8` cannot be shared between threads safely.
= help: within `optee_teec::extension::PluginMethod`, the trait `std::marker::Sync` is not implemented for `*mut u8`
= note: required because it appears within the type `optee_teec::extension::PluginMethod`
= note: shared static variables must have a type that implements `Sync`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] mssun commented on pull request #29: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29#issuecomment-869853390
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] mssun commented on pull request #29: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29#issuecomment-869853390
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] m4sterchain commented on a change in pull request #29: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
m4sterchain commented on a change in pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29#discussion_r656811122
##########
File path: examples/supp_plugin/plugin/plugin_static.rs
##########
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#[no_mangle]
+pub static mut plugin_method: PluginMethod = PluginMethod {
Review comment:
What is the intention to make this data structure mutable? It seems that the [tee_supplicant logic](https://github.com/OP-TEE/optee_client/blob/7c9c423d00e96bf51debd5fe10fd70dce83be5cc/tee-supplicant/src/plugin.c#L85) only needs a constant symbol to look up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org