You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/06/11 17:33:10 UTC
[GitHub] [jena] afs opened a new pull request, #1373: GH-1372: Deliver Fuseki UI as a jar file
afs opened a new pull request, #1373:
URL: https://github.com/apache/jena/pull/1373
GitHub issue resolved: #1372
Pull request Description:
This changes the step that delivers the Fuseki UI built in jena-fuseki-ui to the module jena-fuseki-webapp.
Changes:
* Pack UI into the module artifact jar file.
* jena-fuseki-ui: Change the name from "dist" to "webapp". It is easier to build with the right name at this point rather than mangle file names later because dependency-plug used to unpack the is not string on renaming files.
* In jena-fuseki-webapp uses the dependency-plugin to extract the UI file tree.
`jena-fuseki-ui` is no longer a dependency in `jena-fuseki-webapp` or `jena-fuseki-war`. This wasn't needed and having it causes unused content to bloat the `jena-fuseki-war` file.
----
- [ ] Tests are included. N/A.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/) N/A.
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1373: GH-1372: Deliver Fuseki UI as a jar file
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1373:
URL: https://github.com/apache/jena/pull/1373#issuecomment-1152970204
@kinow - small step to having the UI available in Fuseki Main!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1373: GH-1372: Deliver Fuseki UI as a jar file
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #1373:
URL: https://github.com/apache/jena/pull/1373#discussion_r899548663
##########
jena-fuseki2/jena-fuseki-ui/pom.xml:
##########
@@ -93,6 +93,23 @@
-->
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
Review Comment:
:+1: never used this plug-in directly. Today-I-Learned, thanks @afs !
##########
jena-fuseki2/jena-fuseki-ui/vue.config.js:
##########
@@ -68,7 +68,7 @@ module.exports = {
},
// Change build paths to make them Maven compatible
// see https://cli.vuejs.org/config/
- outputDir: 'target/dist',
+ outputDir: 'target/webapp',
Review Comment:
Ah! That was clever! I'll save that trick for future projects. Much simpler to just output it to `webapp` :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1373: GH-1372: Deliver Fuseki UI as a jar file
Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #1373:
URL: https://github.com/apache/jena/pull/1373#discussion_r899553264
##########
jena-fuseki2/jena-fuseki-ui/vue.config.js:
##########
@@ -68,7 +68,7 @@ module.exports = {
},
// Change build paths to make them Maven compatible
// see https://cli.vuejs.org/config/
- outputDir: 'target/dist',
+ outputDir: 'target/webapp',
Review Comment:
"Clever" is a very scary thing!
We may need to decide on a unique name (e.g. `org.apache.jena.fuseki.webapp`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1373: GH-1372: Deliver Fuseki UI as a jar file
Posted by GitBox <gi...@apache.org>.
afs merged PR #1373:
URL: https://github.com/apache/jena/pull/1373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org