You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jono-morris (via GitHub)" <gi...@apache.org> on 2023/09/22 12:10:40 UTC
[GitHub] [camel] jono-morris opened a new pull request, #11531: CAMEL-19812 use open telemetry naming conventions
jono-morris opened a new pull request, #11531:
URL: https://github.com/apache/camel/pull/11531
Updated camel-tracing to use open telemetry semantic conventions
Following on from this pr: https://github.com/apache/camel/pull/11354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jono-morris commented on a diff in pull request #11531: CAMEL-19812 use open telemetry naming conventions
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #11531:
URL: https://github.com/apache/camel/pull/11531#discussion_r1335632881
##########
components/camel-tracing/src/main/java/org/apache/camel/tracing/decorators/AbstractSpanDecorator.java:
##########
@@ -99,9 +100,14 @@ public void pre(SpanAdapter span, Exchange exchange, Endpoint endpoint) {
span.setComponent(CAMEL_COMPONENT + scheme);
// Including the endpoint URI provides access to any options that may
- // have been provided, for
- // subsequent analysis
- span.setTag("camel.uri", URISupport.sanitizeUri(endpoint.getEndpointUri()));
+ // have been provided, for subsequent analysis
+ String uri = URISupport.sanitizeUri(endpoint.getEndpointUri());
+ span.setTag("camel.uri", uri);
+ span.setTag(TagConstants.URL_PATH, stripSchemeAndOptions(endpoint));
Review Comment:
Yes I think so. I've added it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11531: CAMEL-19812 use open telemetry naming conventions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11531:
URL: https://github.com/apache/camel/pull/11531#issuecomment-1731311548
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jono-morris commented on a diff in pull request #11531: CAMEL-19812 use open telemetry naming conventions
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #11531:
URL: https://github.com/apache/camel/pull/11531#discussion_r1335632881
##########
components/camel-tracing/src/main/java/org/apache/camel/tracing/decorators/AbstractSpanDecorator.java:
##########
@@ -99,9 +100,14 @@ public void pre(SpanAdapter span, Exchange exchange, Endpoint endpoint) {
span.setComponent(CAMEL_COMPONENT + scheme);
// Including the endpoint URI provides access to any options that may
- // have been provided, for
- // subsequent analysis
- span.setTag("camel.uri", URISupport.sanitizeUri(endpoint.getEndpointUri()));
+ // have been provided, for subsequent analysis
+ String uri = URISupport.sanitizeUri(endpoint.getEndpointUri());
+ span.setTag("camel.uri", uri);
+ span.setTag(TagConstants.URL_PATH, stripSchemeAndOptions(endpoint));
Review Comment:
Yes it makes sense. I've added it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #11531: CAMEL-19812 use open telemetry naming conventions
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #11531:
URL: https://github.com/apache/camel/pull/11531#discussion_r1335218660
##########
components/camel-tracing/src/main/java/org/apache/camel/tracing/decorators/AbstractSpanDecorator.java:
##########
@@ -99,9 +100,14 @@ public void pre(SpanAdapter span, Exchange exchange, Endpoint endpoint) {
span.setComponent(CAMEL_COMPONENT + scheme);
// Including the endpoint URI provides access to any options that may
- // have been provided, for
- // subsequent analysis
- span.setTag("camel.uri", URISupport.sanitizeUri(endpoint.getEndpointUri()));
+ // have been provided, for subsequent analysis
+ String uri = URISupport.sanitizeUri(endpoint.getEndpointUri());
+ span.setTag("camel.uri", uri);
+ span.setTag(TagConstants.URL_PATH, stripSchemeAndOptions(endpoint));
Review Comment:
Should URL_SCHEME also be set as a tag ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #11531: CAMEL-19812 use open telemetry naming conventions
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11531:
URL: https://github.com/apache/camel/pull/11531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org